CVS edit link for webmatter

I would like to submit a theme. It is a drupal port of the wordpress theme http://wordpress.org/extend/themes/piano-black

Comments

webmatter’s picture

Assigned: Unassigned » webmatter
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new98.34 KB

This is a drupal port of the wordpress theme http://wordpress.org/extend/themes/piano-black. A theme demo can be found here: http://cinemagie.de/

webmatter’s picture

StatusFileSize
new98.34 KB
webmatter’s picture

Assigned: webmatter » Unassigned
avpaderno’s picture

Status: Needs review » Needs work
Issue tags: +Theme review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site; for modules, it should include also a comparison with the existing solutions.

webmatter’s picture

StatusFileSize
new354.34 KB

Hi, thanks for your reply. As for more features ... the theme has css styles for ubercart thus could be used for ecommerce sites. A link to a working demo was already posted: http://cinemagie.de

I am attaching an additional screenshot of the theme.

webmatter’s picture

Status: Needs work » Needs review

As for the block regions: the theme has the following block regions: right sidebar, footer area, content, below content

mlncn’s picture

Status: Needs review » Reviewed & tested by the community

Tremendous apologies for the long delay in this review coming.

Looks good. Include credit and link to the original project in the .info description, or somewhere, i think.

Also add comments as appropriate to the file type with $Id$ at the top of each file... though maybe you can escape without that until we go to git and that is officially not wanted nor needed.

Also, may be able to adopt more things from the draft CSS coding standards: http://drupal.org/node/302199

But i'm calling this ready to contribute. Thanks!

avpaderno’s picture

Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Status: Needs work » Closed (fixed)
avpaderno’s picture

Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Priority: Critical » Normal
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.