used devel module & it identified the same query running multiple times. ID'ed problem with 6.11; patch is for 6.x-1.x dev.
_nodewords_get_tags_data_query()

CommentFileSizeAuthor
#16 nodewords-n929082-16.patch1.79 KBdamienmckenna
#15 nodewords-n929082-15.patch1.72 KBdamienmckenna
#14 nodewords-n929082-14.patch2.15 KBdamienmckenna
#6 929082-nodewords-dont-make-us-cry.patch1.16 KBdave reid
#5 929082-nodewords-dont-make-us-cry.patch0 bytesdave reid
#1 nodewords-929082.patch991 bytesmikeytown2

Comments

mikeytown2’s picture

mikeytown2 commented
Status: Active » Needs review
StatusFileSize
new nodewords-929082.patch991 bytes
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +v6.x-1.12 blocker

Thank you. Will review this for the next release.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

This function makes me cry.

mikeytown2’s picture

mikeytown2 commented

nodewords has made me cry many times; I opt to get in & get out as quick as possible. I'm sure if you look upstream you can make this faster. Main objective is saving the time it takes going over the network to the MySQL server on another box.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 929082-nodewords-dont-make-us-cry.patch0 bytes

So it turns out that only one line of code in the module calls this function. Hilarious.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 929082-nodewords-dont-make-us-cry.patch1.16 KB
mikeytown2’s picture

mikeytown2 commented

any chance of getting a static in there?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Have you re-tested with devel & 6.x-1.x to see if a static is necessary? I tested this using the latest code and devel says it runs this query 10 times, but each time with a different ID, and each individual ID query was only run once.

mikeytown2’s picture

mikeytown2 commented

I'll recheck when I get back from vacation... nov 10th or so

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

I went ahead and committed #6 to CVS. Re-open if you can confirm that static caching is needed, otherwise I feel ok marking this as fixed for now.
http://drupal.org/cvs?commit=444034

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Closed (fixed) » Needs work

Needs to be re-rolled against the latest 6.x-1.x codebase.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new nodewords-n929082-14.patch2.15 KB

Re-rolled against the current 6.x-1.x codebase.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new nodewords-n929082-15.patch1.72 KB

Re-rolled.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new nodewords-n929082-16.patch1.79 KB

Re-rolled again.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed, again.

Status: Fixed » Closed (fixed)
Issue tags: -v6.x-1.12 blocker

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +v6.x-1.12 blocker

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.