The Views hook_views_plugin() hook in views_xhtml.views.inc has the value for the 'module' array key of the array returned to Views as a string w/o quotes. PHP appears to look for a defined constant for views_xhtml. The patch places quotes around 'views_xhtml' which makes the PHP notice go away.

For what it's worth the error message showed up when I was on update.php and is straight from PHP assuming you have your site set to show errors on screen:


array(5) {
  ["%type"]=>
  string(6) "Notice"
  ["%message"]=>
  string(61) "Use of undefined constant views_xhtml - assumed 'views_xhtml'"
  ["%function"]=>
  string(27) "views_xhtml_views_plugins()"
  ["%file"]=>
  string(83) "/opt/www/tng-fresh/sites/all/modules/contrib/views_datasource/views_xhtml.views.inc"
  ["%line"]=>
  int(19)
}
CommentFileSizeAuthor
views_xhtml.views_.inc_.patch741 bytesjaydub

Comments

mikeytown2’s picture

Status: Needs review » Reviewed & tested by the community

also having this same issue; patch fixes it.

noslokire’s picture

looks good to me!

zeip’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Looks good, committed the fix to close the issue & credit – hopefully no-one uses the 6.x version any more, though.

  • ZeiP committed 7c9968e on 6.x-1.x authored by jaydub
    Issue #929124 by jaydub: PHP notice thrown in views_xhtml_views_plugins...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.