Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Oct 2010 at 02:48 UTC
Updated:
16 Dec 2010 at 00:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
dave reidSubscribing, this was pointed out in an issue that I've been working on and has been pushed to D8. This should still make it in.
Comment #2
dave reidAdding tag....
Comment #3
gddUntagging since this isn't actually really a novice issue.
Comment #4
gddThis is a cleanup of the docblock comments which were really poor. I don't have enough context on this to do the function bodies so I'll leave that for Dave Reid
Comment #5
gddReposting since that last patch was a total bust.
Comment #6
gddAdded function placeholder for delete hook, dave is looking into update and insert
Comment #7
dave reidI think we just may have to do the same thing, like we do with hook_node_insert() and hook_node_update(). Been trying to think of something useful that can be understood with minimal context and am failing.
Comment #8
gddand here is your garbage function patch!
Comment #9
gddComment #10
gddFixing dumb spacing
Comment #11
dave reidLet's remove $query = here. We should probably also use something like $path['alias'] rather than 'foo' => 'bar'.
thaat = that
Powered by Dreditor.
Comment #12
gddComment #13
dave reidOne more small typo.
$path <> $ptah
Powered by Dreditor.
Comment #14
gddI'm the worst core patcher ever!
Comment #15
duellj commentedI would give a little bit more info about the $path param and what the array contains. Seems like the definition in path_save() would be good:
Comment #18
duellj commentedAdded full $path parameter definitions from #15. Should be good to go now.
Comment #19
jhodgdonLooks reasonable to me! Thanks juellj and hejrocker.
Comment #20
webchickLooks great.
Committed to HEAD. Thanks!