Update manager UI uses stale project data [#929756]

I discovered this bug while trying to get cvs_deploy fully working in D7. See #601600: First view of updates report without cached release data reports bogus results for projects running HEAD for background.

Basically, inside update_project_cache() we had some logic to clear our cache of project data on certain pages to make sure that we're not using stale data. Unfortunately, I forgot about this little bit of magic when working on the Update manager UI (e.g. admin/modules/update, admin/appearance/update, and admin/reports/updates/update). We need to add those paths to the list of pages that get their cache flushed, or you get into weird cases you can't recover from, and we'll be printing bogus status values for certain projects. Patch coming soon, stay tuned.

Comment	File	Size	Author
#2	929756-2.update_manager_no_stale_project_data.patch	5.88 KB	dww
#1	929756-1.update_manager_no_stale_project_data.patch	1.23 KB	dww

Comments

Comment #1

dww

we/he/they

commented 3 October 2010 at 01:24

Status:

Active

» Needs review

Status	File	Size
new	929756-1.update_manager_no_stale_project_data.patch	1.23 KB

Comment #2

dww

we/he/they

commented 3 October 2010 at 02:28

Status	File	Size
new	929756-2.update_manager_no_stale_project_data.patch	5.88 KB

Huzzah, with a test! ;)

Basically, I added a test to make sure that hook_update_status_alter() actually works like it's supposed to on both the available updates report and inside the Update manager UI. If you apply this patch, then reverse patch #1, the new test will fail, because when the test hits the Update manager UI, the altered status isn't used. However, with both the test and the fix to update_project_cache(), the test passes, since the altered status works, even on the Update manager UI.

Comment #3

tim.plunkett

he/him

English

Philadelphia

commented 3 October 2010 at 02:48

Status:

Needs review

» Reviewed & tested by the community

Code looks great. And for the tests:
After applying the second patch and running the "Update Contrib Functionality" tests, the result was 181 passes, 0 fails, 0 exceptions, and 47 debug messages. Removing the additions of the first patch, leaving just the tests, the result was 180 passes, 1 fail, 0 exceptions, and 47 debug messages. Beautiful.