I am getting multiple errors on user login, like this:

user.login throws "warning: Parameter 2 to MODULE_NAME expected to be a reference, value given in module.inc on line 483."

Tracked it down to the user_services.inc file: it uses module_invoke_all('user','login', NULL, $user) which is incorrect, because call_user_func_array() doesn't properly handle pass by reference with PHP5.3.

The solution is to replace the two module_invoke_all() functions in the user_services.inc with:

user_module_invoke('login', $array = array(), $user);

I'll post a patch when I get a chance, but wanted to get this out here to save others tearing out their hair.

CommentFileSizeAuthor
#7 services-930100.patch1.11 KBkylebrowning
#5 user_services-930100.patch875 bytesRenee S
#3 user_services-930100.patch881 bytesRenee S
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Renee S’s picture

Renee S CreditAttribution: Renee S commented

Er, sorry, the user_module_invoke() replacements should name what they're doing, ie user_module_invoke('login... and user_module_invoke('logout =)

gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
CreditAttribution: gdd commented

I would love to get PHP 5.3 patches but I don't currently have an environment to test this stuff on so I havent been dealing with it. So please pass them on. If we can get a confirment working version for PHP 5.3 I think that would be worth rolling a new release.

Renee S’s picture

Renee S CreditAttribution: Renee S commented
Status: Needs work » Needs review
FileSize
user_services-930100.patch881 bytes

Patch attached.

Status: Needs review » Needs work

The last submitted patch, user_services-930100.patch, failed testing.

Renee S’s picture

Renee S CreditAttribution: Renee S commented
FileSize
user_services-930100.patch875 bytes

mutter mutter eclipse mutter

marcingy’s picture

marcingy CreditAttribution: marcingy commented

I really really don't like this - drupal doesn't do this anywhere I'm aware of in core.

user_module_invoke('login', $array = array(), $user);

For readability it should be

$array = array();
user_module_invoke('login', $array, $user);
kylebrowning’s picture

kylebrowning CreditAttribution: kylebrowning commented
Status: Needs work » Needs review
FileSize
services-930100.patch1.11 KB

Set to needs review for patch testing and chose marcingy's way of doing things.

kylebrowning’s picture

kylebrowning CreditAttribution: kylebrowning commented
Status: Needs review » Fixed
gateway69’s picture

gateway69 CreditAttribution: gateway69 commented

the $array = array(), makes it work with PHP 5.3

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.