Seems to be working fine on my site. I'm not sure what the issue was that resulted in the project page stating it would only work with the 6.x-1.x branch of Emfield but I'm glad I went ahead and tried it anyway. Either the project page needs to be updated or if someone could provide some background on the potential issues with Emfield 6.x.2.1

CommentFileSizeAuthor
#7 emfieldbug.patch738 bytesramirez.gerardo

Comments

joachim’s picture

joachim commented
Category: task » bug
Priority: Minor » Normal
Status: Active » Fixed

Basically, I put that on the project page because the module was written for the 1.x branch of Emfield, and I didn't have time to try it with the 2.x branch. When in doubt, play safe! ;)

Very glad to hear it works fine with the 2.x branch. I'll amend the project page. Thanks for reporting this!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

davebv’s picture

davebv commented
Title: Works with emfield 6.x.2.1 » Does not works with emfield 6.x.2.3
Status: Closed (fixed) » Active

I get a warning with emfield 6.x-2.3

warning: Parameter 6 to emaudio_soundcloud_audio() expected to be a reference, value given in sites/all/modules/emfield/emfield.module on line 650.

And nothing is showed up.

davebv’s picture

davebv commented
Title: Does not works with emfield 6.x.2.3 » Does not work with emfield 6.x.2.3
ramirez.gerardo’s picture

ramirez.gerardo commented

I found a workaround:

go to line 155 and remove the node reference from the 6 parameter. change it to the following:

function emaudio_soundcloud_audio($embed, $width, $height, $field, $item, $node, $autoplay)

I'm going through the source now to try to wrap my head around it all.

Thanks,

gerardo

joachim’s picture

joachim commented

If you could roll that as a patch that would be great, thanks.

(That's not a workaround, that's a fix!)

ramirez.gerardo’s picture

ramirez.gerardo commented
Version: 6.x-1.1 » 6.x-1.x-dev
Component: Documentation » Code
Assigned: Unassigned » ramirez.gerardo
Status: Active » Patch (to be ported)
StatusFileSize
new emfieldbug.patch738 bytes

I've attached the patch here which solves the following error.

warning: Parameter 6 to emaudio_soundcloud_audio() expected to be a reference, value given in sites/all/modules/emfield/emfield.module on line 650.

joachim’s picture

joachim commented
Status: Patch (to be ported) » Needs review

Thanks!

The correct status now we have a patch is 'needs review', btw :)

This would also need testing with versions of emfield prior to 2.3 -- if this patch breaks those versions, then we will need to specify on the project page that there's a minimum version requirement for emfield.

ramirez.gerardo’s picture

ramirez.gerardo commented

Very cool and thanks for helping me out with this. I'll be sure to test versions prior to emfield 2.3.

Best regards,

Gerardo Ramirez

shadysamir’s picture

shadysamir commented

Patch from #7 works with emfield-6.x-2.5

shadysamir’s picture

shadysamir commented

Same patch from #7 needs to be applied to emaudio_soundcloud_preview() for preview player display

joachim’s picture

joachim commented
Status: Needs review » Closed (cannot reproduce)

Version 6.x-1.3 of Media: Soundcloud works fine for me with Emfield 6.x-2.5.

If you're having a problem with these versions, please reopen with an explanation of how to reproduce the problem.

ufku’s picture

ufku commented
Title: Does not work with emfield 6.x.2.3 » Incompatible with PHP 5.3
Status: Closed (cannot reproduce) » Reviewed & tested by the community

This is reproducable with PHP 5.3.

13rac1’s picture

13rac1 commented
Status: Reviewed & tested by the community » Closed (cannot reproduce)

If you're having a problem with these versions, please reopen with an explanation of how to reproduce the problem.