There are a few places in the Services module where checking for variables being set/existing before checking values are causing the log files to fill up with warnings.

Notice: Undefined property: stdClass::$sid in services_session_load() line 872 services.module
Notice: Undefined index: optional in services_method_call() line 397 services.module
Notice: Undefined index: signed in services_get_hash() line 116 services_keyauth.module
Notice: Undefined index: optional in services_admin_browse_test() line 128 services_admin_browse.inc
etc...

This patch simply adds the proper "isset()" calls before checking the values of these variables.

This patch also includes the patch from http://drupal.org/node/823992

CommentFileSizeAuthor
#5 services-931184.patch3.28 KBkylebrowning
#1 services_931184.patch2.79 KBminoroffense

Comments

minoroffense’s picture

minoroffense commented
StatusFileSize
new services_931184.patch2.79 KB

Status: Needs review » Needs work

The last submitted patch, services_931184.patch, failed testing.

kylebrowning’s picture

kylebrowning commented
Status: Needs work » Needs review

#1: services_931184.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, services_931184.patch, failed testing.

kylebrowning’s picture

kylebrowning commented
Status: Needs work » Needs review
StatusFileSize
new services-931184.patch3.28 KB

Re-rolling of patch. Hopefully this one passes :)

Status: Needs review » Needs work

The last submitted patch, services-931184.patch, failed testing.

kylebrowning’s picture

kylebrowning commented
Version: 6.x-2.2 » 6.x-2.x-dev

I think to get this test to pass we need t be on 6.x-2.x so, gonna try that

kylebrowning’s picture

kylebrowning commented
Status: Needs work » Needs review

#5: services-931184.patch queued for re-testing.

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Fixed

Committed to dev head

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.