emthumb throws a warning when uploading custom video thumbnails. to fix the following on line 206 needs to be changed from:

if (isset($form_state['clicked_button']) && in_array('node_form_submit', $form_state['clicked_button']['#submit']) && isset($form_state['storage']['emthumb'])) {

to:

if (isset($form_state['clicked_button']['#submit']) && in_array('node_form_submit', $form_state['clicked_button']['#submit']) && isset($form_state['storage']['emthumb'])) {

Comments

alex ua’s picture

alex ua commented
Version: 6.x-1.9 » 6.x-2.x-dev
Status: Needs review » Postponed (maintainer needs more info)

I see that line of code, but I'm not getting any errors with PHP error reporting set to E_ALL & ~E_NOTICE. What error do you get exactly?

cangeceiro’s picture

cangeceiro commented

Wrong datatype for second argument in emthumb.module on line 206 was the error i was getting. only happened when uploading a custom thumbnail for videos that are directly linked to an mpg. and only happened when i clicked on upload. since the form hadn't been submitted $form_state['clicked_button']['#submit'] was not getting passed

Oscar Illada’s picture

Oscar Illada commented

Same issues but using the content lock module, this module add a cancel button, and when you press that button you get the same warning. I changed the code you put on the description of this issues and the warning has gone, is there any problem changing this code? can change the behavior of the module?
i'm ussing the 6.x-1.26 version