Performing a login_reset task on a site shows a "Login_reset example.com" in the task summary on the right hand side.
While being minor, I don't think that's very nice. In this case the title of the task is "Reset password" which doesn't fit very well if prepended to the name of the site. So I added a 'summary title' key which is used for this summary. While working nicely it's an awful lot of code for such a small thing, and providing a whole task property just for that is also not the nicest thing on earth, but it's a start. Patch attached.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | no_underscores.patch | 606 bytes | tstoeckler |
| hostmaster_tasks_title.patch | 1.3 KB | tstoeckler |
Comments
Comment #1
Anonymous (not verified) commentedThis would also help my ugly 'Backup_delete' which snuck into beta1.
This problem has been bothering me for a while - but I don't feel confident in saying whether this is the best way :s
The $nodes in the queue block are fetched from hosting_get_tasks() - I wonder if it would be more efficient to store the summary title in the task table and get it from the query to use it, since we already looping on each task node.
Am I saying it would be more efficient to grab the summary title value from the database? I think I am - and that's why I am probably not the best person to say what's the right way, since that's surely wrong logic :)
Comment #2
anarcat commentedHow about just removing the underscore from the display? Would be much simpler, wouldn't it?
I feel unconfortable adding a new field without a) clearly defining what's its purpose and b) outlining why the existing fields cannot be used. Basically, we would end up with 3 descriptors here (login_reset, Reset password and Reset password for...), seems to me there's one too many here.
Comment #3
tstoecklerI guess doing that as a first step can't hurt.
While I don't like my previous very much either, I still think we can do better that "Login reset mysite.com" or "Backup delete mybackup". But I don't really know how to do that in a nicer way.
Anyway here is an untested patch for replacing underscores with spaces.
Comment #4
tstoecklerComment #5
anarcat commentedi just committed the thing lest i forget. :)