Add unlimited option for "total file size per user"

+1 to this. I've had to raise the upload limit on d.o 3 times since the ifac stuff got committed.

subscribe

subscribe

The upload settings form limits us to 99999 MB (~100 GB) per user including the anonymous user. I attached a drupal 6 patch to allow 9999999 MB (~10 TB) per user; although if this won't be accepted in drupal 6 I should probably just fix via form alter. Of course unlimited is the real answer.

I think this is the wrong way to go about this. I think that a value of 0 should be allowed like Syn said, which is a common way of saying unlimited. A little bigger patch would be needed for this, but it wouldn't take too much work.

Here's a patch adding the feature for drupal 7.

So that patch handles settings the max file size to 0, but what about actually using that value in the upload validation code where the check against the user's total file quota usage is calculated? Since 0 really mean 999999999999..., I would think there needs to be some special logic to handle that.

As far as I can tell, the logic already handles a "zero" as unlimited correctly. I did some quick smoke testing and it seems to work, but it should have some more testing.

Committed to CVS HEAD. Thanks mfb. Rock on.

I backported the drupal7 patch that mfb made to Drupal5. Testing shows that it works correctly.

This is a bug on 6 -- reopening.

A bug because the code clearly is written with this in mind:

    // A zero value indicates no limit, take the least restrictive limit.
    $file_size = variable_get("upload_uploadsize_$rid", variable_get('upload_uploadsize_default', 1)) * 1024 * 1024;
    $file_limit = ($file_limit && $file_size) ? max($file_limit, $file_size) : 0;

    $user_size = variable_get("upload_usersize_$rid", variable_get('upload_usersize_default', 1)) * 1024 * 1024;
    $user_limit = ($user_limit && $user_size) ? max($user_limit, $user_size) : 0;

but the UI is not.

Rerolled the patch from #8 above (but without the text on 'least restrictive limit' which is useful but patch creep).

Oops. Setting to needs review.

Bump - the quota can still not be set to zero in Drupal 6

subscribing.

+1 for this up. This would be very usefull.

Subscribing.

+1

+1 don't help nobody. If anybody wants this in, please review!

http://drupal.org/patch/review

Tested, works for me in 6.19.

I was thinking and searching about this and wondering why do the administrators need to restrict the total amount. There should be a choice to let them configure by themselves, not because of the system need. I personally agree with others that this choice should be in the core upload module too. The system shouldn't be that strict, and the admins should be able to choose the zero amount as unlimited. It's kinda freedom thing :) "If you want to limit, you can, but by default there isn't any limit..." If anyone still needs the modified upload.admin.inc file, than that can be found in the attachment (replace it with the original core's file and there u go).

#8: upload.usersize.patch queued for re-testing.