Closed (won't fix)
Project:
Rules
Version:
6.x-1.x-dev
Component:
Rules Core
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
5 Oct 2010 at 19:07 UTC
Updated:
16 Apr 2018 at 04:43 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
giorgio79 commentedHere is a patch. Please check :)
6.1.3 was older than the dev release so I rolled it against 6.1.3
Here is an example for user load by email http://api.drupal.org/api/function/user_load
Comment #3
giorgio79 commentedThe error says: "Ensure the patch applies to the lastest checkotu of the code-base."
Well, too bad. As per the front page 6.1.3 is the latest... All the best test bot.
6.x-1.3 Download (207.11 KB) 2010-Sep-02 Notes
6.x-1.x-dev Download (207.12 KB) 2010-Aug-17 Notes
Comment #4
giorgio79 commentedHmm, just checked out the latest from github as per the front page.
I see these user files have massively changed since the last version...
Comment #5
klausiyou need to create the patch form the rules root directory http://drupal.org/patch/create
Comment #6
giorgio79 commentedThanks, lets try again.
Comment #7
klausiAnd you need to provide the changes in one patch, please.
Comment #8
giorgio79 commentedThanks, lets see.
Comment #9
giorgio79 commentedhoops, wrong direction, lets try this.
Comment #11
giorgio79 commentedeh :D
Comment #12
klausimissing white space before 'mail'
Powered by Dreditor.
Comment #13
giorgio79 commentedThanks, fixed.
Comment #14
giorgio79 commentedComment #15
fagoany testers? :)
@code:
"User mail", "mail", "email" - please be consistent with whatever label you use. Best do it the same way as core.
Comment #16
fagooh
>+ $userarray = array('name' => $settings['username'], 'uid' => $settings['userid'], 'mail' => $settings['mail']);
This will generate a notice for old $settings without 'mail'.
Comment #17
twistedindustries commentedI just used the patch in #13 and it worked fine for what I needed it for. Thanks!
Comment #18
Encarte commentedsubscribing
Comment #19
giorgio79 commentedHey Fago and klausi,
I implemented a simple if else check to see if $settings has mail.
If that is not sufficient, could you give some tips on how could the patch solve the error notice you mention about old $settings?
I also made sure all instances have "mail" as in core. Attaching revised patch
Comment #20
giorgio79 commentedComment #21
giorgio79 commentedComment #23
giorgio79 commentedDon't you love patching?
Comment #25
giorgio79 commentedMaybe from module root :D
Comment #26
klausiplease use braces as required by the Drupal coding standards. Furthermore you have to use isset(), because the 'mail' array key may not be set and could generate a notice. And I think you swapped the if/else branches by mistake.
And please create one patch file that contains all changes.
And please create patches in the new -p1 format, see http://drupal.org/patch/create ;-)
Powered by Dreditor.
Comment #27
giorgio79 commentedMuch appreciated klausi! Thanks for your help. I believe this is ready now.
(Git is awesome, just got my head around it.Patching with it was a breeze, even on Windows :D)
Comment #28
giorgio79 commentedDiscovered a small typo ( a semi colon missing)
Comment #29
philltran commented#28: load_user_action_by_email-932484.patch queued for re-testing.
Comment #30
giorgio79 commentedI notice this is way way better in D7, with the entity property selector. Wow, fantastic. I wont pursue this further.
Comment #31
klausibut maybe others want to pick this up.
Comment #32
tr commentedThis feature is available in Rules in D7 and D8, and won't be implemented in the now-obsolete D6 version of Rules.