Closed (fixed)
Project:
Menu Editor
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Oct 2010 at 02:27 UTC
Updated:
9 Nov 2010 at 22:28 UTC
Jump to comment: Most recent file
Comments
Comment #1
mikeytown2 commentedpatch also takes care of some white space issues.
Comment #2
donquixote commentedThe whitespace is a habit of mine. Always want to give the blank lines full indentation.
Is there a documented style rule that handles whitespace? Otherwise I would try to just keep the module consistent.
Comment #3
donquixote commentedFor the rest:
I didn't know that list($a,$b) is that strict. Error reporting level? Would it help to put a "@" ?
Your patch looks like a reasonable solution.
That said, I do have a local version somewhere which stores these values in the $form array instead of a static var. Seems like a better idea. I should commit this thing to -dev.
Comment #4
mikeytown2 commentedhttp://drupal.org/coding-standards#indenting
My editor auto removes trailing whitespace at the end of a line
And if your up for a challenge use this
http://drupal.org/project/coder
Comment #5
donquixote commentedI committed a minimal fix to the 6.x-2.2 stable release.
The local version with hook_nodeapi and more changes will go into 6.x-2.3
This way, people can revert to 6.x-2.2, if 2.3 should cause any unforeseen issues.
Comment #6
donquixote commented