An example (in code comments) has a select all fields example with no ->fields() method. Maybe this worked once, but in my tests (with D7 head) select all fields is not assumed, and the query gives an error without it.

Patch forthcoming.

Should all examples go in this one module? One group that's missing that i could contribute some for is a select query involving count (and, i hope, group by and more).

CommentFileSizeAuthor
#4 examples-933526-3-dbtng-select-comment-examples-with-fields-method.patch1.09 KBmlncn

Comments

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

I'd love to see a whole section of DBTNG that was just recipes for various things. It doesn't even have to have a UI, just good comments (and tests for each one).

Please make sure your fix comes with a test. (I'm surprised it doesn't have one?)

Thanks,
-Randy

mlncn’s picture

mlncn commented

The example is only in a code comment-- shall i make it a real example?

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

As much as possible we should have real, running queries that can be tested. Thanks! (And of course the comments should be correct)

What I have in mind is in #718672-7: DBTNG Example needs more examples

mlncn’s picture

mlncn commented
Status: Active » Needs review
StatusFileSize
new examples-933526-3-dbtng-select-comment-examples-with-fields-method.patch1.09 KB

Status: Needs review » Needs work

The last submitted patch, examples-933526-3-dbtng-select-comment-examples-with-fields-method.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Needs review

Passes now.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Fixed

Committed to HEAD: http://drupal.org/cvs?commit=436224

Thanks so much!

mlncn’s picture

mlncn commented
Status: Fixed » Closed (fixed)

Thanks, i was pretty sure comment-only changes weren't what were upsetting the testbot!