Closed (fixed)
Project:
Panels
Version:
5.x-1.2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Nov 2006 at 04:47 UTC
Updated:
14 Jan 2008 at 14:03 UTC
Jump to comment: Most recent file
Hi, Great module! I love it. The attached install file will allow it to work with PostgreSQL.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | panels_postgres_5.patch | 2.28 KB | HorsePunchKid |
| #4 | panels_postgres_4.patch | 1.5 KB | HorsePunchKid |
| panels.install.txt | 1.5 KB | redsky |
Comments
Comment #1
merlinofchaos commentedThis will go out in v1.1. Thanks for the patch!
Comment #2
(not verified) commentedComment #3
pearcec@drupal.org commentedSome how this got munged when it got committed. The dbtype should be db_type. I also noticed the BRANCH 5 2 version is completely different from the BRANCH 5 1 version in CVS. I am not certain if this branch is going to be used, but the pgsql table creates will not work the same as mysql. I am going off of this version:
// $Id: panels.install,v 1.1.4.4 2007/04/03 16:36:05 merlinofchaos Exp $
convert dbtype to db_type.
Comment #4
HorsePunchKid commentedSorry, I didn't find this issue until I had already created a patch to fix the issue. It fixes the
dbtypeversusdb_typeissue, a number of Postgres problems, and various style issues (improper tabbing and such). The patch is against thepanels.installfrom the official 5.x-1.2 release.Comment #5
HorsePunchKid commentedThis patch restores the sequence that Postgres needs for the PK on the
panels_infotable and fixes a problem with the autocomplete query, which was using double quotes for a SQL string instead of single quotes. So far, everything else appears to be working as I'd expect!Comment #6
HorsePunchKid commentedIs there a reason the
didcolumn forpanels_infohas the sequence namepanels_info_id_seqinstead ofpanels_info_did_seq? I was going to submit a patch to use the Postgresserialtype instead, but that won't work if the sequence isn't actually named after the column name. Perhaps this isn't worth addressing on this branch, though...Comment #7
catchassuming this got fixed, please re-open if not.