Hi, Great module! I love it. The attached install file will allow it to work with PostgreSQL.

Comments

merlinofchaos’s picture

Status: Active » Fixed

This will go out in v1.1. Thanks for the patch!

Anonymous’s picture

Status: Fixed » Closed (fixed)
pearcec@drupal.org’s picture

Version: 4.7.x-1.x-dev » 5.x-1.2
Status: Closed (fixed) » Reviewed & tested by the community

Some how this got munged when it got committed. The dbtype should be db_type. I also noticed the BRANCH 5 2 version is completely different from the BRANCH 5 1 version in CVS. I am not certain if this branch is going to be used, but the pgsql table creates will not work the same as mysql. I am going off of this version:

// $Id: panels.install,v 1.1.4.4 2007/04/03 16:36:05 merlinofchaos Exp $

convert dbtype to db_type.

HorsePunchKid’s picture

StatusFileSize
new1.5 KB

Sorry, I didn't find this issue until I had already created a patch to fix the issue. It fixes the dbtype versus db_type issue, a number of Postgres problems, and various style issues (improper tabbing and such). The patch is against the panels.install from the official 5.x-1.2 release.

HorsePunchKid’s picture

Title: PostreSQL Support (install file attched) » PostreSQL Support
StatusFileSize
new2.28 KB

This patch restores the sequence that Postgres needs for the PK on the panels_info table and fixes a problem with the autocomplete query, which was using double quotes for a SQL string instead of single quotes. So far, everything else appears to be working as I'd expect!

HorsePunchKid’s picture

Is there a reason the did column for panels_info has the sequence name panels_info_id_seq instead of panels_info_did_seq? I was going to submit a patch to use the Postgres serial type instead, but that won't work if the sequence isn't actually named after the column name. Perhaps this isn't worth addressing on this branch, though...

catch’s picture

Status: Reviewed & tested by the community » Closed (fixed)

assuming this got fixed, please re-open if not.