If you want to place two panes next to each other by setting their css display property to inline-block, it won't work properly since there is a line feed at the end of the last line of the file panels-pane.tpl.php. This produces a gap between the two inline-block divs.

Though it is simple to create a copy of the template in the themes directory without this line feed, I would prefer an origin template without it.

Unfortunately, I was not able to create a useful patch file, since the removed line feed is not registered as a differing line. Therefore, I request you to remove the line feed by hand by using an editor which does not automatically add a line feed at the end of each file.

http://drupalcode.org/viewvc/drupal/contributions/modules/panels/templat...

Display in Netbeans IDE which makes the line feed at the end of line 53 visible:

48   <?php if ($more): ?>
49     <div class="more-link">
50       <?php print $more; ?>
51     </div>
52   <?php endif; ?>
53 </div>
54

Comments

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Active

1) Needs review means there is a patch attached. No patch.

2) Typically we try to have a line feed at the end of files to keep patch from complaining about it.

3) I can't see how a line feed prevents two divs from going inline. You'll need to explain this to me.

kle’s picture

kle commented

Hi merlinofchaos !

Yes - I too had this problem.
The line feed is interpreted as a space in most Browsers.
So both panes are not neatless beneath each other.
HTML: [pane1]horrible space[pane2]

Is it possible to clear the empty line ?

Greetings from Germany

chx’s picture

chx commented
Status: Active » Closed (won't fix)

Templates can be overridden if a space bothers you.

merlinofchaos’s picture

merlinofchaos commented
Status: Closed (won't fix) » Active

I've been thinking about this issue, and it occurs to me that the problem may be that you're trying to set a pane inline when you should not be trying to set a pane inline.

Maybe what you really want to do is to set the pane to have use the "no markup at all" style, which can be inline if the inner content is inline.

eclipsegc’s picture

eclipsegc commented
Status: Active » Closed (works as designed)

inline html elements respect spaces, which I assume the crlf is being interpreted as. You should not be attempting to write placement html for panels panes in any event. You SHOULD be writing your own layout plugins, utilizing mini-panels or something similar.

eclipsegc’s picture

eclipsegc commented
Status: Closed (works as designed) » Active

Marking back active per what merlin had

merlinofchaos’s picture

merlinofchaos commented
Status: Active » Closed (won't fix)

Actually I only reactivated because of cross-post. I think closed (won't fix) is best here. I do think the answer is that if the 'no markup' style isn't appropriate, we need a separate style for panes meant to be inline. Otherwise I feel like you're putting a square peg into a round hole.