Closed (cannot reproduce)
Project:
Drupal core
Version:
7.x-dev
Component:
update system
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Oct 2010 at 06:06 UTC
Updated:
22 Oct 2010 at 01:54 UTC
Jump to comment: Most recent
Comments
Comment #1
Argus commentedMore messages
The update process was aborted prematurely while running update #7006 in node.module. All errors have been logged. You may need to check the watchdog database table manually.On clicking the 'logged' link to http://localhost/?q=admin/reports/dblog (same message is given on Frontpage):
PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'drupaldb1.block_node_type' doesn't exist: SELECT module, delta, type FROM {block_node_type}; Array ( ) in node_block_list_alter() (line 2339 of D:\wamp\www\modules\node\node.module).Back to http://localhost/update.php?op=results:
Notice: Undefined index: update_success in update_results_page() (line 162 of D:\wamp\www\update.php).Comment #2
Argus commentedRemoved all (themes, files, modules) subdirectories from all subsite's directories and run the install script again. This time it ended normally giving the following error's:
Main page gives:
Comment #3
Argus commentedThis was an upgrade from 6.19 to 7.0-beta1
Comment #4
varontron commentedSame here. Upgrade 6.19 to 7.0-beta1. Failed 7006 4 times.
Had to add
field_data_comment_body.comment_body_valueandfield_data_comment_body.comment_body_formatmanually to get the update (7006) to take. Usedcomment.commentandcomment.formatrespectively as guides for field defs. Altogether had to run update.php 4 or 5 times. Crossing fingers.Comment #5
webchickTagging, so we get some people to look into this.
Also changing component since this has to do with the upgrade path, not the ajax system.
Any other details you folks can provide would be wonderful!
Comment #6
Argus commentedPossibly the same as http://drupal.org/node/934468: "sites/all/modules was not empty (still some Version 6 Modules)"?
If this is the case then there should be a simple check if sites/all/modules and sites/xyz/modules contain Drupal 6 modules, if so a warning "please remove all old modules before continuing the update" should be given. Just so ignorant people like myself think they can update from Drupal 6 to Drupal 7 without removing old modules. :)
Will check this later today in my install.
Comment #7
webchickHm. Does #895140: _system_rebuild_module_data() and _system_rebuild_theme_data() will choose 6.x versions of modules and themes over 7.x versions help with that at all, by any chance..?
Comment #8
Argus commentedI'm not a coder, but I understand that issue discusses a patch to prevent someone trying to update from 6.0 to 7.0 with /sites/all/modules still containing 6.0 modules?
But that patch wasn't committed yet in 7.0-beta1?
I suppose once the damage is done there is no way to repair it other then restoring a backup? If so then I will just do a clean install.
These updates remain pending:
Comment #9
mcrickman commentedDuring upgrade from 6.19 to 7 beta 1 I have same problem as #2.
This is the error on the website.
FYI: When I ran the update.php I was given the access denied page and had to set the
$update_free_access = TRUE;in the settings.phpCharlie
Comment #10
mcrickman commentedI got the upgrade to work I had to completely remove the version 6 cck directory for it to work. I did receive this info on the completion screen.
But I no longer get the error on the website.
Also I didn't do a restore of the site I simply removed the cck directory and re ran the update.php.
Charlie
Comment #11
Argus commentedRemoving all v6 sites/all/modules and sites/xyz/modules doesn't change anything in my case
Comment #12
mcrickman commentedI had to manually added the two fields (comment_body_value & comment_body_format) to the (field_data_comment_body) table to get the upgrade to complete without errors.
Comment #13
webchickK, well. Enough people are reporting this issue that I think we need to escalate it to critical.
Thanks for testing! Let's get to the bottom of this. :)
Comment #14
graytoby commentedI ran into the issue as well. Update fails on #7002 and #7007. I tried on linux, latest apache, mysql, php 5.3 and wamp with apache 2.2.11, mysql 5.1.36 and php 5.3 and 5.2.11, php and apache logs are completely empty. I tried both 7.0-beta1 and latest dev version, no luck. Below are errors from update result
Comment #15
webchickHuh. It looks like the sidebar block only picks up issues assigned to "7.x-dev", so re-assigning. I'll make a separate bug report about that.
Comment #16
catchArgus - you can't recover an installation where the upgrade failed, or not easily. If you have you have a backup, please try again with no Drupal 6 modules around.
varontron, mrickman, spongecat - please post here whether you have any D6 modules in your Drupal install, especially CCK.
I think this is a duplicate of #895140: _system_rebuild_module_data() and _system_rebuild_theme_data() will choose 6.x versions of modules and themes over 7.x versions but would be good to confirm that either way before closing.
If anyone is getting this without having D6 modules around, we might need a dump of the D6 database to test with.
Comment #17
webchickOk, #895140: _system_rebuild_module_data() and _system_rebuild_theme_data() will choose 6.x versions of modules and themes over 7.x versions has now been committed.
Could folks in this issue please try your upgrades again from scratch, using the latest, bleeding-edge code in CVS? (and/or wait ~12 hours for the new 7.x-dev.tar.gz file to be generated.) I suspect it should now be fixed.
Comment #18
graytoby commentedcatch - I have a lots of modules, including cck. All were disabled though and sites/all and sites/default/files dirs were emptied completely. I tested it on local copy of production site.
Comment #19
yoroy commentedI ran into this ajax http error with Beta1. Tried again just now with a fresh checkout and did not see the error anymore so seems to be fixed indeed. Is 1 succesful test enough to mark this fixed then?
Comment #20
damien tournoud commentedUpdate #7007 Failed: PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '4-administer recommender' for key 'PRIMARY': INSERT INTO {role_permission} (rid, permission) VALUES (...)That's probably the culprit.
But contact_update_7002() should also depend on the user_update_7007().
Comment #21
yoroy commentedWelll, I still get reports that update 7006 still needs doing but that one keeps failing
Comment #22
Anonymous (not verified) commentedFYI I had this error but then after reading this issue queue I removed my old 6 modules from sites/all/modules, tried again and it worked fine, upgraded with no errors.
Comment #23
effulgentsia commentedI'm concerned that "critical" and "postponed" is a bad combination now, because "postponed" issues don't show up in the "X Critical issues" contributor link, so they don't get nearly enough attention, which isn't good if it's truly "critical".
@DamZ, @yoroy: can you please make new issues for #20 and #21, if that's still needed.
What else is needed to close this?
Comment #24
effulgentsia commentedFor everyone who reported the bugs, thank you, and please, please, keep doing so, but I think it makes sense to close this issue, because:
1) It's not 1 issue. It's at least 3 issues.
a) The originally reported issue is node_update_7006() calling text_summary(), but text_summary() not existing. I'm unable to reproduce this with either a 6.19 to 7.0-beta1 upgrade or a 6.19 to HEAD upgrade. And code-wise, there doesn't appear to be anything identifiably wrong. node_update_dependencies() lists system_update_7049() as a dependency, and that runs after system_update_7027(), which enables text.module, so it shouldn't be possible to have text_summary() not existing when node_update_7006() is running. Unless D6 CCK's text.module is being loaded instead of the D7 text.module. But now with #295255: Clean-up the upgrade path: UPGRADE.txt just landing, our instructions clearly say to remove D6 modules for which there are new D7 modules.
b) #10 is comment_update_7006() querying 'comment_body_value' and 'comment_body_format' columns of {field_data_comment_body}, but those columns don't exist. But comment_update_7005() creates the comment_body field, including its columns, unless again, there's D6 CCK modules lying around and causing conflict.
c) #14 is contact_update_7002() and system_update_7007() failures that don't appear to have anything to do with CCK. I haven't put much time into trying to reproduce these. @spongecat: if you're still seeing those, please open a new issue with steps on how to reproduce this, like "install Drupal 6.19, enable modules x, y, z, add roles a, b, c, and users foo and bar, then upgrade to Drupal 7, ...".
2) There's some evidence (#19) that HEAD has fewer of these problems than beta1.
3) Having this issue be open but postponed hasn't been useful in getting further information.
So, again, closing this issue, and encouraging new issues to be opened, specific to the actual update function failing, if anyone is finding problems with HEAD, using its new and improved UPGRADE.txt instructions.
Comment #25
effulgentsia commentedOh, and as per #17, in addition to better UPGRADE.txt instructions, HEAD is now better about prioritizing D7 modules over D6 modules that may be lying around.