Posted by fago on October 7, 2010 at 10:48am
3 followers
Jump to:
| Project: | Project Issue File Review |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
From time to time the testing bot throws "unable to find class RulesLog" errors. Perhaps some qa testbots have troubles with class autoloading?
see http://qa.drupal.org/pifr/test/94679
Generally the tests work, and most times also the bot gives a green light.
Comments
#1
Still, this issue applied and seems to occur randomly. Recent test run where it happened: http://qa.drupal.org/pifr/test/27274
#2
I think you'll find that this is a problem with fragile tests, rather than a problem with the testbot. The testbot is just running simpletest here. We have a few core tests that occasionally fail for the same reason.
Most common issues: Using random strings that eventually match something, etc.
#3
I don't think this is an issue with fragile tests, as the problem is not that some assertions fail - no the whole test cases fail! Also, I never ran into such a test fail locally and I usually run those tests on a daily basis ;)
-> thus re-assignin to pifr.
If the pifr log shows any error message, it is:
"unable to find class RulesLog" As said above, this sounds like some qa testbots have troubles with class autoloading as the class is in the module but loaded via the autoloader.
#4
OK, well let's see if we can find out if it's one particular testbot that gives this result.
Thanks for your patience.
Not sure how we're going to figure this one out.
Do you need more privs on qa? I'd be more than happy to give them to you. Just create an account over there and let me know about it.
#5
>Do you need more privs on qa? I'd be more than happy to give them to you. Just create an account over there and let me know about it.
Sounds good! I've created an account -> "fago".
#6
@fago, you have "pifr admin" role on qa, which means you can initiate retests and do a number of other things ordinary users can't.
Thanks!
#7
Thanks!
At http://qa.drupal.org/pifr/test/27274/tools the entity module is missing in the dependencies. I'm sure that worked some time ago (before my vacation, so ~March) though. Has the dependency handling somehow changed? Is it necessary to use the 'dependencies' key in getInfo() now even for dependencies listed in .info files?
#8
I am unfamiliar with any loading of external dependencies that ever worked with PIFR. It's my top priority, and is blocked by #102102: Parse project .info files: present module list and dependency information, so I'm spending all of my available time on that one. There have been lots of changes, due to the git migration and such, but I never did know of external dependency loading working. It never worked on Token Example in Examples, which is where I first ran across the problem.
There are a pile of issues waiting on #102102: Parse project .info files: present module list and dependency information, including #698932: Soft dependencies / integration tests, so I hope we can make progress here. I'm thinking that I'll have a first-look version this week sometime.
#9
I've never known this to work properly, like rfay says.
#10
Interesting, it did already work for Rules & Profile2. Also, for the entity API I had a "soft dependency" (just required for the tests) working by adding the module to the 'dependencies' key of the getInfo() method. Not sure, whether this still works due to #1144472: Entity API tests try to enable a not existing module and fail.