QA: Search Results pages [Theme]

the search engine works at a good performance speed. the results are excellent. all links are working. from the functionality perspective the page is working fine.

but i have some remarks from the design-perspective:
right below the "sort by"-textfield above the search results (it is "order by" in the prototype) there is a search button which is not in the prototype. it took me about a minute to figure out what this button does. then, of course, it's obvious.
if you ask me, i would kick this button out and connect the action of sorting with the drop-down-field behind the "sort by"-textfield. this is much better usability than using a button, because if a person uses the drop down field, a click is saved if the chosen action is done right away and not after having to click another button.

my second remark is the drop down-list "refine your search": in my browser (ff 3.6.10, macbook pro 15') i can see an ugly scroll-down-bar in this drop down list which is unnecessary.

please understand my remarks as personal taste. again, the functionality of the page works fine and the search results are great.

I added some JS to submit the order form when something is chosen from a dropdown, and hid the button.

Please attach a screenshot of the refine search scroll bar.

Sending back for another round of QA.

I tested the new JS search auto submit and it worked.

Here's a screenshot of the 'refine your search' scroll bar issue:

Assigning to Drumm

Note that the 'refine your search' dropdown appears without the scrollbar in some browsers:
Chrome 6.0.472.62 - OS X: Appears as expected
Opera 10.63/Mac - OS X: Appears as expected
Safari 5.0.1 - OS X: Appears as expected

Adding a overflow:visible; on #search-theme-form-advanced fieldset.collapsible .fieldset-wrapper fixes the dropdown scrollbar issue in OSX/Firefox.

There appears to be a z-index issue with the advanced search dropdown in IE7, see attached screenshot (Win XP/IE7).

Subscribing

Now that I added All, it would be ideal to put these in two columns. Is there a better way to do this than shuffling the source order and float: left? We want to keep modules and themes together.

@drumm, I'll investigate. At worst, would be reordered with JS.

Related issue: #935240: QA: Search Box (Home) [Theme]

Tag

Lets not do JS, rearranging the DOM is slow and we have a server to make the right HTML.

I got this working purely with CSS -- it uses specific IDs as targets. Will be visible on http://redesign.drupal.org shortly

Nevermind, had some problems in IE. Will update again shortly.

Committed this change, currently launch is taking place so this might not be immediately visible.