Patch (to be ported)
Project:
Guitar
Version:
6.x-1.1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Issue tags:
Reporter:
Created:
8 Oct 2010 at 07:46 UTC
Updated:
9 Oct 2010 at 18:48 UTC
I added the output name of the chord.
tnx to tune5b
| Comment | File | Size | Author |
|---|---|---|---|
| 0-2-2-1-0-0.png | 738 bytes | topy | |
| 3-2-0-0-0-3.png | 771 bytes | topy | |
| x-x-0-2-3-1.png | 835 bytes | topy | |
| guitar_diagram.test | 8.76 KB | topy |
Comments
Comment #1
topy commentedYou can see my result here
PS I added number of string and rotate the image (like guitarists likes)
PPS sorry for my English
Comment #2
floretan commentedAdding the chord name inside of the image is nice, but it has the following disadvantages:
1. You need to modify the image generation function in order to modify the appearance. Adding the chord name as text after the image (by overriding the theme function) lets you use CSS and all of its possibilities.
2. Chord diagram images have their filename based on the finger positions only. However, the same chord can have two different names. For example, [x,1,3,3,3,1] could be either Bb or A# major.
However, the option to add a background color to the fretboard and rotating the image to display the strings horizontally is interesting and would be a nice feature to have. If you have a patch to add such functionality I'd be happy to integrate it into the module.
Comment #3
topy commentedI can't write the patch, but can describe you how i did it.
Thus:
1. I took the code from here (thanks to tune5b) to get the background color.
2. I added $im = imagerotate($im, 90, 0); before "Create the image file" sting.
Thank you for your nice job.