port to 5.x

Yes, I am going to do this soon.

Any update on this?

Thanks

David

I am going to be working on this when I go away over Christmas and just after the new Year I plan to create a beta.

Thanks Gordon

I'm also interested in the 5.x version and am willing to help if you need any. I've got 4.7 level patch posted under a separate issue for review that adds a feature to simple_access to allow it to let users share access to nodes to access groups that a user is not a member of.

Any feedback on whether you're interested in folding this feature into simple_access. I've been using this patch in a production environment for more about 6 months now, and it seems to behave pretty well. I'd be happy to resubmit this patch for the 5.x version if you'll let me know when is the right time.

Any update? I would like to contribute too, i can port the module to general compatibility with 5.0, but i don't understand NAA yet...And i need this module :)

Next in line... :)
It would be great to have this module soon - hope gordon will find some time and help us out.

This looks like exactly the module I need and I would definitely like to use it in a 5.x site.

Question: Can I have an entrance page whose text changes based on whether the role allows the user into that section?

I would also like Simple Access to work under Drupal 5.

+1 nice module. Also interested in porting to D5. Do you have patches available at the moment?

+1 I'm missing this module my drupal 5.1 website

+1 - Here too, its great....and its also missing for Drupal 5

Count me in on Drupal 5 :)

Can see that gordon is extremely busy with E-commerce module, so I've started working on a patch for this.

Gordon,

Let me know if you start working on this, and I'll be happy to send you the code I've developed so far. I've finished implementation of simple_access_access_records hook and am working on UI components now.

If you give me access and want, I'd be happy to commit these changes as I get tests completed. Otherwise, I'll just roll the patch and post it here when done.

subscribing

Here's a somewhat tested version of simple_access. It appears to work on PHP 5 at least. I'm uploading the full module as a convenience, but I'll also upload the patch in case gordon would rather work with that .

And the patch version.

Oh and in the interest of full disclosure this also has the patch for embedded in it.

http://drupal.org/node/79171

thanks for the patch, this is a great start. unfortunately, i've run into a handful of problems trying out the patched copy on a clean 5.x test site.

• the message after you enable the module isn't formatted correctly and isn't translatable (it doesn't use t()).
• after configuring everything properly (and even as uid 1), the "Access" fieldset is just empty until you "Save configuration" on admin/settings/simple_access. basically, some places we're calling variable_get() aren't using the right default value if there's nothing in the db.
• lots of code-style issues (indentation, commented out lines that shouldn't be there, etc).
• ...

so far, in limited testing, otherwise, things seem to work ok. i haven't tried using SA and another module like OG, but we should definitely test that, too, to make sure the node access arbitrator (NAA) stuff is working right.

i'll work on cleaning up the stuff i mentioned above right now and see if i can get a new patch posted in the immediate future. stay tuned.

oh, and deleting groups on admin/user/simple_access doesn't work. ;)

fixed:
- confirm form for deleting groups
- logic for the node form when no settings have been saved
- (tons of) code formatting/indentation/whitespace problems
- version field in .info file
- menu descriptions
- messages when you enable/disable the module

also:
- removed some dead/needless code
- added some comments

tested heavily on a clean 5.x site, and all is working now. i'll try testing an upgrade site, too (which i'll need to do a couple of for production sites i care about, anyway). ;) however, i think this is RTBC. anyone else care to confirm that?

thanks,
-derek

p.s. since i use simple_access on all of my real drupal sites, i have a keen interest in its health. i'd be happy to help out as another committer if the current maintainers want any additional help. thanks.

hehe, the patch. ;)

Thanks I have committed this to HEAD, but still needs a lot of work to get it running correctly with Drupal 5, and remove a lot of code that is no longer needed.

Thanks guys

FYI I am dependent upon this module as well, I'd be happy to test (unfortunately I've got little php coding knowledge and can only test for now). Thanks for all the work everyone is putting in to this exceptional module.

@jseal: great, thanks for the offer. good testing is often just as important as writing the code itself, so please contribute however you can. that said, if you find bugs using the HEAD version of this module on a 5.x test site, please look at the issue queue to make sure it's not already a known bug, and then submit a new issue. thanks!

to clarify (since i mixed singular and plural when i didn't mean to)...

if you find new bugs, please submit each one as a separate, new issue. makes it easier to deal with that way.

thanks,
-derek

Why was this closed? This is the only place I've seen patches for (partial) 5.x operation.

OK, I see now that this patch was committed (I did not think it was). Sorry. I will provide separate issues as needed.