Remove Views column when statistics not enabled

Which handler?

Michelle

Ah, that one. I've "won't fix'd" that in the past because it's not a bug but rather a configuration error. If you don't enable statistics, you need to remove that column. I was going to add that to the docs but I'm going to have a crack at handling it in code. I discovered I can conditionally include the menu option in views and maybe I can conditionally include that column as well. It's a little messy because it will break if you override the view but anyone that overrides the view usually knows what they're doing so it's probably the lesser of two evils.

Michelle

Nah, not going to re-invent the wheel. Just conditionally add it only when the axle is avalable. :)

Michelle

What about patch like this in selected views (added at the end of file)? Works for me in D7...

if (!module_exists('statistics')) {
  unset($handler->display->display_options['fields']['totalcount']);
  unset($handler->display->display_options['style_options']['columns']['totalcount']);
}

... but still, I'd like to have statistics built-in AF as Michelle said in #1038430: Adding Statistics module as a dependency to .info

Adding them and then unsetting them doesn't make much sense to me. I would just put the module_exists test around the code that adds them to begin with.

Michelle

On second thought, your method does make more sense now that I look at it since the code in question is buried in the middle of a huge array so we can't put an if test just around that bit. Working on that now but I'm at camera club and I have some other uncommitted changes so might not get committed tonight.

Michelle

Committed to 6.x. Moving this to 7.x. Sorry the commit is too messy to make a patch out of. I had some other stuff in progress that ended up going along with it and I'm gonna try and get it sorted before the next dev snapshot. In the future I'll try to make clearer commits so you can more easily port things to 7.x. Not used to having a co-maintainer. :)

Michelle

Don't worry Michelle, I'll find the way :)

Ported and committed.

Thanks!

Michelle

At this moment installing amazon setting the field in views y get this error
Notice: Undefined variable: type in views_get_handler() (line 872 of C:\wamp\www\drupal-7.x-dev\sites\all\modules\views\views.module).
Notice: Undefined variable: type in views_get_handler() (line 872 of C:\wamp\www\drupal-7.x-dev\sites\all\modules\views\views.module).
the path above would work ?
I am new with drupal , i may need further explanation how to work a patch