Port Smileys to Drupal 7

Hello,

Could I ask what the status is on this port? Do you have a more recent/better patch?
How much work is needed?

I have a demo D7 RC1 site I can test this on.

Best regards,
Ao

I tried testing the patch as is, to see if I could understand what errors may appear. However, after applying the patch I can see the module in my site's module list, but trying to enable it does nothing. I don't even get any error.

I don't yet have the knowledge to go through the sources to update the code on my own, especially without having anything to go by. Thank you for any time you may have spare to look further into this.

Best regards,
Ao

subscribe

Smileys working with wysiwyg api would be great...

Subscribe

subscribing as well

Any news or progress?
Or a alternative module?

http://drupal.org/project/customfilter could be an alternative module to smileys for D7! Maybe also a starting point for a new smileys module?

I've started a rewrite for Drupal 7.
First I had a look on the provided patch, but I think it's more difficult to change a lot of code than doing it clean and fresh. In the next days I'll provide a first dev Version. It will be compatible to the D6 Version.

@svenrissmann:

Wonderful, thank you. :-)

Best regards,
Ao

subscribing

Sorry for taking so long on doing this!
I´ve a working one on Drupal 7 now an it looks pretty well. Just the admin section is still missing but that´s not such a big thing!
Because of a lot of things from the 6.x are not needed by me I´ve left them there!
Especially all the fancy JS and UI stuff is not of my taste and I just don´t need it at one of my sites!
So for this reason, I want Gurpartap to decide if this realy should become a 7.x branch of his module.

I´m not realy sad if Gurpartap would decide against my work, because of it just fits my needs and such a little module doesn´t realy need much work once it´s stable!

Great news! I'm excited about testing it. :-)

Best regards,
Ao

subscribe

@svenrissmann: Will you be able to post some code soon? I don't think Gurpartap will give this project much love anymore, I have tried to contact him in the past and he did not reply. Maybe you can ask him about taking over the project or something?

Best regards,
Ao

subscribe

Subscribe

@svenrissmann we can test your code if you can provide us your work ...

Subscribe

I've made an emoticons module. Now it's in my sandbox and ready to use.
You can get last snapshot and help me to test it.

Thank you, Chi! I will begin testing it as soon as possible. =)

Best regards,
Ao

sub

Anyone with a patch or interest to upgrade and maintain smileys for D7? Chi?

I can maintain D7 version of this module.

Renaming for better tracking ...

@Chi I think no reason to duplicate modules so better to find/replace in your code which mostly is good and commented.
Also fix .info file - no need to put any inside files[] til your code does not contain class definitions (files section used for class registry)

I've mark as fixed you request #1098672: Emoticons
So please contact @Gurpartap Singh about access and provide a patch in this issue, when we clean it's code-base (you code mostly clean enough) you could make a beta release and community start work on upgrade path and import submodule

I just fit my needs and I'm not going to start separate project if D7 version of smileys will be released.
Here is renamed version of the module. I think it's ready to be committed as part of the Smileys module.

Subscribe

Subscribe

Subscribe

subscribe

@Chi is there any git sandbox to fetch current version of you work?

I see no ability to review 450k patch with binary data :( But I glad to join to your efforts

http://drupal.org/sandbox/Chi/1095624
I've added dereine and andypost to maintainers list.
Everybody who want to join are welcome.

subscribe

I'm sorry: I dindn't understand: is, with the patch, the module compatibile whit 7.x?

I would like a 7.X smileys

thanks for the patch :), can maintainers upload the new D7 version in the dev list module?

Subscribe

@Chi:
Could you request to take over the smileys module as maintainer? It's annoying to get no response or reaction from the maintainer...

By which way i can do it? Read #22 and #23. Is there any special procedure for this?
Smileys is abandoned module and it has no maintenance status: seeking new maintainer. There are some guidelines for this – dealing with abandoned projects but i don't believe that it will be helpful.
The Drupal community follows the ethos collaboration rather than competition. From this point D7 version of smileys will never been released and it is a weight on my mind.
So we have what we have.

I don't know how to maintain or take over a project but if maintainer not answer a d.o admin/ moderator should give you the rights... Or you should create a new project. It's terrible to work with patches or without modules like smileys...

I dunno. It looks like the guidelines are fairly easy to follow.

#1. Make a support topic here asking for Maintainer-ship.

#2. In the event that the request is ignored for 2 weeks, enlist the aid of: http://drupal.org/project/webmasters with a detailed report of the situation.

Waiting for official release for d7 :)

Anyone picking this module up?
Anyways, heres a filter tips callback

/**
* Filter tips callback
*/
function _smileys_filter_tips($filter, $format, $long = FALSE) {
  $tips = t("Smileys are enabled");
  
  if($long) {
    $header = array('', t('Acronyms'));
    
    $result = db_select('smileys', 'sm')
      ->fields('sm')
      ->condition('status', TRUE)
      ->execute();
    
    $smileys_path = variable_get('smileys_path', drupal_get_path('module', 'smileys') . '/packs');
    $rows = array();
    foreach ($result as $key => $smiley) {
      $rows[$key][] = theme('image', array('path' => $smileys_path . '/' . $smiley->uri, 'alt' => 'smiley'));
      $rows[$key][] = check_plain($smiley->acronyms);
    }

    $tips .= theme('table', array('header' => $header , 'rows' => $rows, 'attributes' => array('id' => 'smileys-overview')));
  }
  
  return $tips;
}

This module allows to use Smileys Chi's port 7 (from post #35) with Wysiwyg module for Drupal 7 and CKEditor.

I've never used sandbox or git. What is the best way to get the sandbox files for Smileys? I enabled git in my drupal account but don't understand what to do in the sandbox.

Is Chi's sandbox version working on Drupal 7 for anyone?

Does anyone know of any other way to use smileys/emoticons in the Drupal 7 forum?

Getting a sandbox is unrelated to enabling git in your account. You need to install the 'git' program on your machine, and then run the command which you see listed on the sandbox page:

git clone http://git.drupal.org/sandbox/Chi/1095624.git smileys_7

Unfortunately that's the only way I know.

And yes. Chi's sandbox is working for me.

Does this sandbox version for Drupal 7 include the smileys select box for comments & forums?

I tried the Drupal 7 version posted in #27 here and it works but it is stripped of the select box scripts.

• @ssace: No, it doesn't. I think it must be a separate module.
• @roderik, @ssace: Last snapshot can be found at Sandbox -> Repository viewer -> Tree.
• @Wooster, @roderik: That's just too bureaucratic for me.

Now is the time to start thinking about port Smileys to Drupal 8.

Any patches or suggestions about smileys select box are welcome.

I'm using Chi's port without problems. If Chi doesn't want the bureocracy maybe someone should take this role.

D8 port? ;)

Is there any chance of somebody taking this over officially, if for no other reason than being able to download and enable this module using drush?

I was planning a migration from PHPBB3 to include migrating any custom smilies, but I'm not sure what mod to target.

@ comment 51 - the snapshot function from gitweb seems to have been turned off so you can no longer get a snapshop from there.

I'm willing to take over maintainership of this module, both D6 and D7, then create a D7 release based on Chi's work.

I'll update this issue when that's done.

awesome!!!

Well, things didn't turn out the way I planned, so I forked the module :P

http://drupal.org/project/smiley

One of my considerations for forking was that this project is officially minimally maintained and bug fixes only.

You can see #1397854: Offering to maintain Smileys for the details of my offer to maintain this project.

Cheers,
Yonas