Closed (fixed)
Project:
Filebrowser Extensions
Version:
master
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Nov 2006 at 14:29 UTC
Updated:
30 Jan 2007 at 10:55 UTC
When a empty folder is expanded, a page opens up in the tree and the message is:
Unable to get files for this directory 'foldername'
sorry
This is in firefox, IE6 and Opera give error messages when an empty folder is opened.
Instead of this, can the expander render a better text like 'Empty folder' or something that is consistent with the the look and feel of the tree?
Comments
Comment #1
dman commentedUsing the file-listing function available at the time, I think I was unable to distinguish between empty, null, non-existant and unreadable folders.
Thus the message was 'no results' rather than 'empty'
The error I imagine is due to trying to insert a text message directly into a table, sometimes the DOM manipulation complains like that, but we can probably fix it.
I'm doing 14-hr days at the moment, so it'll take a while to get to it,
Comment #2
deepak.sathya commentedActually, The code has a means of checking for empty folders for raw mode but the error is triggered before that. I have partly fixed it (will post back once it works right).
I wanted to remove links to the folders so that just the expander works. I think this will also stop from the links straying out of the node into context when filebrowser is embedded in a node.
A hint on where to start on this one would be helpful.
Comment #3
dman commentedAvailable columns include:
name : A link to the short file name. Links to folders open new requests, so don't use this with the AJAX methods
file : The icon and file name together. Directories are not linked, but have classes embedded to make this useful for AJAX callbacks. Files are linked to launch in a new window.
The labels aren't great, but this is explained in 'about columns' found on the settings screen.
Comment #4
dman commentedAlso, Each of the columns operates as a hook-style callback, so you are welcome to invent any new custom column you want in another module or theme and just invoke it by name,
Comment #5
dman commentedFixed long ago IIRC