book.module is not updating the database

*taptap* is this thing on?

Here's the code that looks like it's not doing what it's supposed to:

/**
 * Implementation of hook_update().
 */
function book_update($node) {
  if ($node->revision) {
    db_query("INSERT INTO {book} (nid, vid, parent, weight) VALUES (%d, %d, %d,
%d)", $node->nid, $node->vid, $node->parent, $node->weight);
  }
  else {
    db_query("UPDATE {book} SET parent = %d, weight = %d WHERE vid = %d", $node-
>parent, $node->weight, $node->vid);
  }
}

If $node->revision? I don't even know what this means. The only page I could find with a reference on the node object says "Revision number?" Not exactly inspiring. Drupal needs some, like, useful documentation someday.

But what makes me think of this is where I look further down:

/**
 * Implementation of hook_submit().
 */
function book_submit(&$node) {
  global $user;
  // Set default values for non-administrators.
  if (!user_access('administer nodes')) {
    $node->weight = 0;
    $node->revision = 1;
    $book->uid = $user->uid;
    $book->name = $user->uid ? $user->name : '';
  }
}

So like, if you don't have the access right to administer nodes, then you get these values set for you. That seems very odd. Where are they set if you DO? Why would we want to specify a weight only for non-admins? This makes no sense to me :( I guess this is why comments are important.

I would try creating a new user like that but it doesn't seem to want to let me right now, off to go file another bug report.

I went in and commented out lines 119, 120, and a closing brace } just a bit lower to enable the outline tab for books. It turns out that if I outline the books, they can be properly added to the book hierarchy. The only problem of course is that pathauto will not generate me a new path if I add them to the book in this fashion. If I then go in and edit the book page and save it, a new path is generated as appropriate.

At this point I guess the plan is to outline all of the book pages manually, then delete the aliases for all nodes whose type is book page, and finally use pathauto's settings to force alias creation. What a PITA.

I still want to know wtf $node->revision does...