Hello EugenMayer - thanks very much for making your Content Moderation module available! I have been trying to find evidence of the module's triggers and rules (from content_moderation.trigger.inc and content_moderation.rules.inc respectively). I've enabled the triggers module (along with content_moderation and content_moderation_workflow_ui).

On the admin page /admin/build/trigger/content_moderation, I see a tab for Content Moderation triggers, but no triggers defined (a blank page under the tabs).

I've also been looking at /admin/rules/trigger and see no evidence of Content Moderation-related triggers.

I've tried this both with the default Content Moderation states/transitions as well as with customised ones.

I have started debugging the _content_moderation_node_transition_matrix function in content_moderation.module and the trigger and rules .inc files, but I'm amazed no one else has reported a problem - are these working for everyone else?

CommentFileSizeAuthor
#11 triggers-screen.gif4.97 KBscottAtRoot802

Comments

eugenmayer’s picture

eugenmayer commented

Well iam not using rules / triggers, i just implemented it for the community. AFAIK i have tested triggers back then, when i implemented them and i had feature requests regard "extending rules support" of people which had the rules support up and running.

There have been changes to the matrx-generateion function lately (last release), probably something went wrong there?

lightweight’s picture

lightweight commented

Thanks - I'll have a look and see if I can fix it. If I can, will submit a patch.

lightweight’s picture

lightweight commented

For the benefit of those following this issue here, I've submitted a patch on github: http://github.com/EugenMayer/content_moderation

lightweight’s picture

lightweight commented

Further to that, I've added 'current user' and 'node author' arguments to the rules definitions to make them more useful - you have tokens you can use which refer to those entities in conjunction with your actions.

eugenmayer’s picture

eugenmayer commented
Status: Active » Needs review

thank you very much for the fix! i have added your changes for further testing in http://github.com/EugenMayer/content_moderation/tree/rulestriggersfix
I plan to include it in the next release, but we should test it once again before i merge it back to the master

eugenmayer’s picture

eugenmayer commented
Status: Needs review » Fixed

will be included in 1.10

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tbenice’s picture

tbenice commented

Hi, I badly need this patch because I lost all of my rules events upon updating and cant seem to recover from it.

However, I can't find the patch on github.

Can you please help me out? I'd really appreciate it!

Thanks,

Ted

eugenmayer’s picture

eugenmayer commented

https://github.com/EugenMayer/content_moderation/commit/831f37369f651312...

Its already part of the master branch, so just use the master. Could you do me a favour and report back if its working fine for you, when you test it? thanks

tbenice’s picture

tbenice commented

So far so good. The events reappeared with no problem. Thanks!

scottAtRoot802’s picture

scottAtRoot802 commented
Status: Closed (fixed) » Fixed
StatusFileSize
new triggers-screen.gif4.97 KB

Hi EugenMayer,

I've just started using Content Moderation and everything works great, with exception of triggers. As previously stated by dlane, I too see a tab for Content Moderation triggers, but no triggers defined (a blank page under the tabs). I've confirmed that I am using the patched files. Am I missing something?

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

gmarton’s picture

gmarton commented

I installed 1.10 triggers appear but tokens do not work when sending an email.
It does not seem to pick up token values. Here is the log:

Error sending e-mail (from gmarton@xyz.com to [author-mail]).
This may be the reason the did not work in the first place.

My workaround was not to use Content Moderation Triggers for now, but send author "Content" trigger when post is updated. Tokenized emails work from there.

namita21’s picture

namita21 commented

I have installed Content Moderation module and its working great but only thing I am not able to figure out is how to send email notification to the users like contributor and approver after the state of the node changes like from draft to review.
While using triggers, under content moderation tab nothing shows up, I have used triggers and actions before they work fine but not with this module.
Is there something I am missing ? Also I am not able to find any patch discussed in this thread.

eugenmayer’s picture

eugenmayer commented

Well i think the triggers / rules integration can just be extended to be more useful. Esp. the "email" part is something you often need i guess. So just provide patches so we can include proper contexts and also useful default actions. Perfect way to contribute guys :)

CraigBertrand’s picture

CraigBertrand commented

I don't know if this was ever fixed, but the rules events still do not show up. I am not a php coder so I am afraid I can only test.

Just started using Content Moderate today and will post more bugs if I find some.

Fantastic Module! Great Job!