Closed (outdated)
Project:
getID3()
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
11 Oct 2010 at 03:13 UTC
Updated:
21 Nov 2024 at 10:21 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
skwashd commentedAttached is a patch against the 1.1 release that solves the problem. Now the variables are set first which stops getID3 killing the installation.
You will need to use -p1 to apply the patch. Is there some reason why Drupal Commons isn't using CVS or some other public VCS? I would make creating patches a lot easier.
I tested the patch using Aegir and the standard browser installation methods and both worked fine.
Comment #2
mstef commentedThat definitely fixes it? Still seems like the required variable is set after getId3 is installed.
Comment #3
skwashd commentedRecent testing is now inconclusive. Marking as needs work due the fact that it isn't reliable.
Comment #4
mstef commentedPerhaps it's getID3 that should be patched?
Comment #5
boztek commentedI seem to remember that barracuda / octopus ships with a commons platform. Perhaps we should review what they did to get it going as well?
Comment #6
mstef commentedReally? Got a link?
Comment #7
skwashd commentedomega8cc use the well documented symlink hack - http://github.com/omega8cc/nginx-for-drupal/blob/master/aegir/barracuda/...
I plan to test a patch to getid3 tonight before I crash or first thing in the morning.
Comment #8
mrfelton commentedSubscribe
Comment #9
skwashd commentedThis slipped right off my todo list. I will try to work on it this week.
Comment #10
skwashd commentedThe problem with installing Drupal Commons and any other installation profile which depends on the getID3 module that the module is overly harsh on misconfigured environments.
The attached patch downgrades the errors to warnings when sites are installed via drush (and also Aegir). I am open to rerolling the patch to always use REQUIREMENT_WARN in getid3.install. I understand the reason for the fatal in getid.module, except when Aegir or drush is responsible for the install.
This is my first patch under buyaline, to learn more visit http://buyaline.drupalgardens.com
Comment #11
skwashd commentedReassigning to getid3 queue and attaching patch.
Comment #12
skwashd commentedFixing status
Comment #13
skwashd commentedUpdate title be more accurate
Comment #14
kostajh commentedThis patch works well for me, thanks!
Comment #15
drewish commentedI think the ternary would be clearer:
$severity = defined('DRUSH_BASE_PATH') ? REQUIREMENT_WARN : REQUIREMENT_ERROR;Comment #16
astonvictor commentedI'm closing it because the issue was created a long time ago without any further steps.
if you still need it then raise a new one.
thanks