The attached patch adds a field to admin/settings/messages/notify allowing you to specify the from email address used in private messages.

This is useful if you want an email address other than the main site email address to receive out of office messages, delivery failure reports or replies to notifications.

CommentFileSizeAuthor
#13 pm_email_notify_from_address_v2.patch1.8 KBrsaddington
#10 pm_email_notify_from_address_v2.patch1.74 KBrsaddington
#7 pm_email_notify_from_address.patch1.36 KBrsaddington
#5 pm_email_notify_from_address.patch1.36 KBrsaddington
#2 pm_email_notify_from.patch1.39 KBrsaddington
pm_email_notify_admin_from.patch733 bytesrsaddington
pm_email_notify_module_from.patch615 bytesrsaddington

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs work

Please provide a single patch file, from the privatemsg top directory and set the status to needs review :)

rsaddington’s picture

rsaddington commented
Status: Needs work » Needs review
StatusFileSize
new pm_email_notify_from.patch1.39 KB

Rolled into a single patch file for review....

Status: Needs review » Needs work

The last submitted patch, pm_email_notify_from.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Not really sure what the problem is in your patch, how did you create it?

With cvs, you should use "cvs diff -up".

See also http://drupal.org/patch/create

rsaddington’s picture

rsaddington commented
StatusFileSize
new pm_email_notify_from_address.patch1.36 KB

Recreated patch, fingers crossed this works....

rsaddington’s picture

rsaddington commented
Status: Needs work » Needs review
rsaddington’s picture

rsaddington commented
StatusFileSize
new pm_email_notify_from_address.patch1.36 KB

noticed an error with filename in that last patch, uploading fixed.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

Great, just two remarks...

+++ pm_email_notify/pm_email_notify.admin.inc	2010-10-11 11:58:30.000000000 +0100
@@ -30,6 +30,14 @@ function pm_email_notify_admin_settings_
+    '#title' => t('From address for notifications'),

Thinking about a better label for this setting, not sure. Core just uses "E-mail address". Maybe something like "From e-mail address for notifications"?

+++ pm_email_notify/pm_email_notify.admin.inc	2010-10-11 11:58:30.000000000 +0100
@@ -30,6 +30,14 @@ function pm_email_notify_admin_settings_
+    '#description' => 'This is the email address that notifications will come from. Leave blank to use the site default.',

This needs to be translated with t().

Powered by Dreditor.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Oh, and you also need to add a variable_del() to pm_email_notify_uninstall().

rsaddington’s picture

rsaddington commented
StatusFileSize
new pm_email_notify_from_address_v2.patch1.74 KB

Thanks for your feedback Berdir.

I've implemented in the attached.

rsaddington’s picture

rsaddington commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, pm_email_notify_from_address_v2.patch, failed testing.

rsaddington’s picture

rsaddington commented
Status: Needs work » Needs review
StatusFileSize
new pm_email_notify_from_address_v2.patch1.8 KB

Lets try that again...

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Great, thanks for working on this, commited!

Needs to be ported to 7.x-1.x-dev...

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Patch (to be ported) » Fixed

Ported and commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.