After applying the filter to an image, all attempts to access the site fail with the message:

Fatal error: Call to undefined function file_directory_path() in /home/ww7ba/mobilesoftwaredev.com/sites/all/modules/image_resize_filter/image_resize_filter.module on line 671

CommentFileSizeAuthor
#7 image_resize_filter7_update.patch6.2 KBquicksketch
#6 938442-image_resize_filter-avoid-file_directory_path.patch1.07 KBflorisla

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Postponed

Yeah, beta 1 of Drupal 7 removed that function. I'm not working on updating my modules to Drupal 7 any more currently, after too much frustration of every single module I've ported breaking. I'll wait a few more releases and report everything then. If you can provide a patch I'd be happy to review it.

billsdesk’s picture

billsdesk commented

Before working on a patch for this module, I need to work on patches for other modules for which I am not receiving any responses from the developer. There are actually a couple of modules that I may port to D7 just because I like the D6 module.

Scott J’s picture

Scott J commented

Here is the core issue, for anyone wishing to look at this: #895308: Remove file_directory_path()

And the documentation: http://drupal.org/update/modules/6/7#file_directory_path

florisla’s picture

florisla commented
Title: Use of resize results in Fatal Error » Avoid file_directory_path() function (not present in D7)

This issues looks very similar to insert module #918958.

Probably the same fix (replace with file_default_scheme()) can be applied.

quicksketch’s picture

quicksketch
he/him
commented
Status: Postponed » Active

Putting this back to active now that D7 is in RC.

florisla’s picture

florisla commented
Status: Active » Needs review
StatusFileSize
new 938442-image_resize_filter-avoid-file_directory_path.patch1.07 KB

In that case, we need a patch!

This seems to work for me, although I'm not sure it's correct in all cases.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed
StatusFileSize
new image_resize_filter7_update.patch6.2 KB

Thanks for the patch florisla. It did indeed get the most common situation running, but we still had multiple locations where file_directory_path() was used, plus some other updates necessary. This patch updates the following:

- Now works with private file system.
- Now works with Image module's styles (similar to our previous ImageCache support).
- image_resize_filter_delete_recursive() is no longer needed, we can use file_unmanaged_delete_recursive().

Other changes are definitely still necessary (removing upload.module support for example), but this does seem to get things working for the most part again. I'll release new alphas of Image Resize Filter for D7 shortly.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.