Posted by tatroo on October 11, 2010 at 7:09pm
2 followers
Jump to:
| Project: | Station |
| Version: | 6.x-2.x-dev |
| Component: | Schedule |
| Category: | bug report |
| Priority: | major |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
Our radio station has a specialty show scheduled from Saturday midnight to 3am. The schedule will not display this program IF the time is shifted at all. I would love to start the time slots at 8am.
Comments
#1
At first I thought this was just a duplicate of #843948: Next Scheduled Program Block doesn't wrap to next week. But I don't understand your bug report. What do you mean by "if the time is shifted"? And how does this relate to 8am programs?
#2
I think this is an issue with the new start and end times - saying that he would like the schedule to start at 8am and go until 3am the next day.
Reproduced on my dev site - running the dev version so its a problem in HEAD as well:
http://fwheil.xen.prgmr dot com/wonypod/node/11
(replace the dot com, you know the deal)
I set the schedule to start at 8am and to finish at 3am the next day. Height is set to 3em in case it matters.
If you go to http://fwheil.xen.prgmr dot com/wonypod/node/11/view/sunday you can see the show is scheduled to be 12 midnight to 3am Sunday and shows up fine in the day view, but not the week view.
I also discovered that the schedule won't let you say a show starts on Saturday at midnight (or even 11pm) and goes until Sunday at 3pm - it gives an error saying that the start time must be after the end time. May need to go through and redo that handler, that feels like its just checking the times for sanity and not the combo of day and time.
#3
The only idea I can come up with is removing the "start time < end time" validation.
If someone puts Thursday 6pm to Thursday 4pm, it should assume that it's a 6 day, 22 hour long show.
In that case, it will either be caught by the overlap-validation, or they'll end up with a 166 hour show and they'll realize the problem.
Does that make any sense?
#4
I think that's probably the more sane / expected behavior for the second part of the problem. Do you think that will fix the display issue though? I'm not familiar with that bit of the codebase at all.
#5
I'm pretty sure the views code is failing for the same reason. It can't handle a start time that is "smaller" than the end time. I'll get into the code tomorrow night, hopefully.
#6
Thank you refreshingapathy for figuring out what I was trying to say, and thank you Tim for addressing it. Much appreciated.
#7
This is due to #120296: Add start and end times to schedule grid not working 100%. The problem is that Saturday evening doesn't know to display early Sunday programs (assuming you've adjusted the schedule's start/end times). It should just be a matter of tweaking the db_query() to adjust for schedule start/end times, hopefully I'll be able to get it figured out by the weekend.
#8
I just saw the comment for the #843948: Next Scheduled Program Block doesn't wrap to next week. Is this a temp fix for this issue as well?
#9
No, but I wish it was!
As I said in #7, it is due to a bug in the start/end time shifting. If you leave your schedule as 12am-12am, you won't have any problem.
I'm swamped right now, but I hope to be able to revisit this sometime this month.
#10
Leaving this for the new maintainers. Sorry.