The nodewords canonical url does not work when a module is using hook_term_path. It currently returns a hard-coded taxonomy/term/% path.

The correct method should be to invoke taxonomy_term_path for it to get the correct system path for a taxonomy term.

CommentFileSizeAuthor
#7 nodewords-n938538-7.patch674 bytesdamienmckenna
#6 nodewords-n938538-6.patch1.15 KBdamienmckenna
nodewords.patch538 bytessean-gnu

Comments

sean-gnu’s picture

sean-gnu commented
Assigned: sean-gnu » Unassigned
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +v6.x-1.12 blocker

Tagging this. We want the next release to be rock solid, so if you have some time please help test the v6.x-1.x-dev release to see if all of the above issues are resolved.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Current patch looks like it is no longer necessary. I couldn't find any use of 'taxonomy/term' in the latest code. Re-open if this can be re-confirmed with the latest code.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Closed (fixed) » Needs work

This may need some work, given we've reverted everything back to the last changes on December 31st, 2009.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 6.x-1.11 » 6.x-1.x-dev
Status: Needs work » Needs review
StatusFileSize
new nodewords-n938538-6.patch1.15 KB

I re-rolled the patch against the latest 6.x-1.x codebase and included a comment line.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new nodewords-n938538-7.patch674 bytes

Re-rolled.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: -Nodewords

Don't need to add a tag for the module name.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)
Issue tags: -v6.x-1.12 blocker, -taxonomy_term_path

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +v6.x-1.12 blocker, +taxonomy_term_path

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.