The setting for the "Show 'Give Userpoints' links beneath nodes" checkbox is not remembered when the Userpoints settings form is submitted and always returns to a selected/checked state.

I unchecked the box for "Show 'Give Userpoints' links beneath nodes" on the /admin/settings/userpoints settings page. When I returned to the page, the checkbox was selected/checked again, but, in fact, the "Give Userpoints" link was not appearing my nodes (the box should not have been selected/checked). Saving the /admin/settings/userpoints page again without making any changes to any settings on the page reactivated the "Give Userpoints" link on all nodes again.

This bug requires that we always remember that editing any of the settings on the /admin/settings/userpoints page also requires that the "Show 'Give Userpoints' links beneath nodes" checkbox be unchecked each time before saving the settings or the "Give Userpoints" link will be reactivated.

CommentFileSizeAuthor
#3 fix_default_value.patch954 bytesberdir

Comments

IWasBornToWin’s picture

Same here....who should we contact? This post is over a month old.

dmetzcher’s picture

@IWasBornToWin: kbahey is the maintainer of the module/package of modules, but this ticket is the proper way to contact him about the bug we've found. It looks like he updated the module's project page a few days ago, so he might be working through the tickets, adding new modules to the package as they are ported by the community, and leaving this ticket until he's finished. I can understand that, because the bug we've found isn't really critical. I only wanted him to know about it in case he wasn't aware.

berdir’s picture

Status: Active » Needs review
StatusFileSize
new954 bytes

Well, the setting is weird in the first place :) The only thing you can control is if they should be shown on page content types, all other will show them by default. In the D7 port, we replaced it with a list of content_types so you can select on which ones it should be shown.

Anyway, fixing this is simple, please try the attached patch.

Status: Needs review » Needs work

The last submitted patch, fix_default_value.patch, failed testing.

berdir’s picture

Status: Needs work » Needs review

#3: fix_default_value.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, fix_default_value.patch, failed testing.

berdir’s picture

Status: Needs work » Fixed

Something is wrong with the testbot for user2userpoints, commited anyway.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.