I've installed drupal 5, beta 1 and implemented the sites/all directory

I currently have a structure like this

sites
  |_all
     |_modules
     |     |_foo
     |        |_foo.module
     |
     |_themes
         |_bar_theme

In the comments for the function it states $directory for example being 'modules' but then later it sets up sites/all like so...

// Always search sites/all/* as well as the global directories
$searchdir[] = 'sites/all';

I believe it should be
$searchdir[] = 'sites/all/' . $directory;

this would put it in line with how config and profile are set up...
$searchdir[] = "profiles/$profile/$directory";
...
$searchdir[] = "$config/$directory";

I attached a patch (just a one line fix). (let me know if it is in the correct format)

CommentFileSizeAuthor
#3 common.inc_49.patch514 bytesskeen
#2 common.inc_48.patch483 bytesskeen
common.inc_47.patch483 bytesskeen

Comments

skeen’s picture

Status: Active » Needs review
skeen’s picture

StatusFileSize
new483 bytes

I read the handbook for creating patches and the coding standards for string concatenation so I think this is a patch in the correct format and using Drupal coding standards....

skeen’s picture

StatusFileSize
new514 bytes

ok, sorry, I swore i saved the file before uploading?? I guess not though, here is the correct patch

drumm’s picture

Status: Needs review » Fixed

Committed to HEAD.

Anonymous’s picture

Status: Fixed » Closed (fixed)