Hey Leighton, just a quick ping to say that we've updated the module package naming. All standalone contributed modules should use the Commerce (contrib) package name as indicated here:
http://www.drupalcommerce.org/development/standards#packages
Hey Leighton, just a quick ping to say that we've updated the module package naming. All standalone contributed modules should use the Commerce (contrib) package name as indicated here:
http://www.drupalcommerce.org/development/standards#packages
Comments
Comment #1
Anonymous (not verified) commentedI updated the name of the project, let me know if it is correct now. I've also added you as a maintainer.
Sincerely,
Leighton Whiting
Comment #2
rszrama commentedCool, thanks Leighton. Did you commit to CVS yet?
Comment #3
sven.lauer commentedFixed in the repository.
Comment #4
klonosWhile at it, it should be "Commerce (bulk product creation)" instead of "Commerce (Bulk Product Creation)", in order to comply to drupal coding standards (only the first letter of the first word allowed to be capitalized). More info here: #1103208: Projects' names should be checked in .info files for correct capitalization.
Comment #5
klonos+ proper tags too ;)
Comment #6
sven.lauer commentedThanks for catching this!
Fixed. Dropped the parens, too, as that seems to make sense.
Comment #7
sven.lauer commentedComment #8
klonos...sorry to activate again, but you missed the parentheses there: "Commerce bulk product creation" should be "Commerce (bulk product creation)" because according to commerce contrib "satellite" modules naming suggestion - it should be in the form of
Commerce (contrib module name).PS: sorry if I am busting b@@ls here with my perfectionism.
Comment #9
sven.lauer commentedChanged it back. And no apologies---that is what coding standards are for, after all.
I wonder though ... where do I find this recommendation? It's not at http://www.drupalcommerce.org/development/standards ...
Comment #10
klonos...sure it's there: http://www.drupalcommerce.org/development/standards#packages
Actually I went through that article just now and located the specific paragraph. I think that I originally heard about it in a video from a drupalcon though. You'll see that exact naming being used in a bunch of other Commerce related projects out there ;)
Comment #11
sven.lauer commentedIf I may nitpick myself ;):
What is talked about there is only the _package_ name (emphasis mine):
And the following example makes that clear:
Note that the module name in this example is "Commerce PayPal" (no parens), while the suggested package name is "Commerce (PayPal)"---because PayPal may have multiple dependent modules that are usefully grouped together.
(I do believe that what you say is (at least a de facto) standard, but it does not say so in the coding/dev standards. If it is indeed the recommended package name, it should be clarified there.)
Comment #12
klonos...that's right. I believe it was Ryan mentioning it in this video (also linked in Commerce project's page too) from DrupalCon Copenhagen.
Comment #13
rszrama commentedYeah, you don't need to put the module name in parentheses. Also I see "Commerce" as a prefix or dependency designation, not so much part of the module name... so to throw even more confusion into this topic, you could call the module "Commerce Bulk product creation", "Commerce BPC", "Commerce Bulk Product Creation", or anything else you want. ; )
The only thing that really matters from a standards perspective is that the package name in the project's .info file is "Commerce (contrib)" so it gets lumped in with all the other contrib modules. : )
Comment #14
klonosAh, thanx for taking the time to clarify all this Ryan! All this time I was reading "package" and my mind was interpreting this to "project" somehow. Silly me ;)
...though the module names you suggest conflict with drupal naming/coding standards - but I understand you only mean to make a point. Actually, I think "Commerce BPC" is ok though (acronyms are an exception to the capitalization rule).
Comment #15
sven.lauer commentedHm, I think I'll leave it as is for now. "Commerce BPC" is not a good choice, as it really is not descriptive.
Comment #17
michelleSee #1346158: Decide on coding standard for capitalization of module names [policy, no patch] and #1430452: Use Proper Name Case for core modules for current information on this policy.
Comment #18
klonos...yep, the standard has changed and it now allows (more likely suggests) Proper Name Case instead of the Sentence case for module/theme names. The Sentence case policy remains for UI text like widget labels for example.