system_ip_blocking() defines the variable $output, but it doesn't use it.

CommentFileSizeAuthor
#12 939918-9.patch697 bytesjoetsuihk
#8 939918-8.patch533 bytesamateescu
#6 939918-2.patch716 bytesjoetsuihk
#2 939918.patch737 bytesjoetsuihk

Comments

bleen’s picture

bleen commented
Issue tags: +Quick fix, +Novice

someone can learn how to create a patch with this

joetsuihk’s picture

joetsuihk commented
Status: Active » Needs review
StatusFileSize
new 939918.patch737 bytes

nice tag.

please try my patch.

Status: Needs review » Needs work

The last submitted patch, 939918.patch, failed testing.

bleen’s picture

bleen commented

joetsuihk - it looks like your patch is failing because patches always need to be relative to the root of you drupal install

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: documentation » other

That means the filename should be modules/system/system.admin.inc; the patch should be then created using the arguments -u -p.

joetsuihk’s picture

joetsuihk commented
Status: Needs work » Needs review
StatusFileSize
new 939918-2.patch716 bytes

obviously netbeans CVS is not good enough to cater different path for patches.
manually edited the patch

Status: Needs review » Needs work

The last submitted patch, 939918-2.patch, failed testing.

amateescu’s picture

amateescu commented
Status: Needs work » Needs review
StatusFileSize
new 939918-8.patch533 bytes

Here's one that should work :)

joetsuihk’s picture

joetsuihk commented

it is sad that netbeans CVS client do not work at all...
but @amateescu use git?
we can start using http://git.drupalcode.org/project/drupal.git to create patches?

amateescu’s picture

amateescu commented

Yes, i used git following this guide: http://drupal.org/node/707484

droplet’s picture

droplet commented

@joetsuihk

check it out: http://drupal.org/node/551858

joetsuihk’s picture

joetsuihk commented
StatusFileSize
new 939918-9.patch697 bytes

@amateescu thx, will try later

try on my linux with cvs following:

http://drupal.org/node/320
http://drupal.org/patch/create

just want to try if my patch works on tests

droplet’s picture

droplet commented
Component: other » system.module
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice catch!

Committed to HEAD. Welcome to the core team, joetsuihk! :)

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix, -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix, +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.