Use oauth_callback to pass current domain when authenticating

subscribing.

Having similar problem with:
one.example.com
two.example.com
...

Subscribing

I'm surprised that specifying a different domain in the callback is allowed, as I would have thought Twitter would restrict that. However, I think it could be desirable to test this and get it into the module. Could you roll a patch against the current dev?

Yes, that's what I was asking. There are a lot of open issues on this module, and I don't have a lot of time, so I'll generally try to encourage people to get issues as close to committable as possible. If rolling a patch is prohibitive for you, can you check that the line number hasn't changed in the current dev release?

Patch attached, $params is now optional for $twitter->get_request_token();

+1 for this change, but having trouble applying the patch:

Hunk #2 FAILED at 314.

Trying against 3.0beta2, but also tried against -dev.

Not sure where the main focus is on this module, but assuming development focus is on Drupal 7 I can confirm the the patch in #9 applies and works as required on the current 7.x-3.x-dev

Just re-rolling this patch in the correct git -p1 format

Hi guys - I think this is an excellent functional enhancement for the twitter connect feature as well.

I was simply wanting to have mydomain.com and www.mydomain.com work with the twitter_signin.module, so I added your logic to the token generation there, and it works like a charm.

Here's the patch from #12 but with the sign in bit added.

Any chance to have a similar patch for 6x ?
Thanks

The last patch works pretty well for me.

+1 to adding this functionality.

Patch needs updating for 7.x-5.x-dev. Does not apply anymore.

$ git apply twitter-oauth-callback-940060-13.patch 
twitter-oauth-callback-940060-13.patch:57: trailing whitespace.
  
twitter-oauth-callback-940060-13.patch:61: trailing whitespace.
  
error: patch failed: twitter.lib.php:331
error: twitter.lib.php: patch does not apply
error: patch failed: twitter.pages.inc:290
error: twitter.pages.inc: patch does not apply
error: patch failed: twitter_signin/twitter_signin.module:81

Triggering the testbot.

Triggering the testbot.

Rerolled, though untested.

Fixed a bug in twitter_oauth_callback_form_validate() with an undefined $token variable.

Rerolled.

Rerolled.

Ported to 7.x-6.x.

Ported to 6.x-5.x.

Forgot that the callback URL was updated to be loaded from a variable. This is for 7.x-6.x.

Ported to 7.x-5.x.

Committed. Thanks all!