New patch for ImageCache 2 (latest version in DRUPAL-6--2 branch)

This is not for HEAD, but for the latest version of the 2.0 branch.

My patch was against http://drupalcode.org/viewvc/drupal/contributions/modules/imagecache/ima..., which is included in version 2.0 beta 10.

Your patch is against http://drupalcode.org/viewvc/drupal/contributions/modules/imagecache/ima..., which is not yet included in any release.

I've *added* your patch, instead of altering the existing one. The existing one is still needed for people using version 2.0 beta 10. Many people are still using that version, because it's the latest recommended release. Unfortunately, this means I had to update the README.txt and UPDATE.txt, as well as the checking of requirements.

Committed an updated version of the patch (also attached): http://drupal.org/cvs?commit=435476.

There was a problem with the verifying if the ImageCache 6.2 patch had been applied. Committed a fix: http://drupal.org/cvs?commit=436426.

I applied the included patch (imagecache_6--2.patch) to the latest dev release of imagecache, but the cdn module continues to report that it's not applied.

@Eidolon Night:
Same situation for me: I am using CVS name versions for modules directories.

In other words: imagecache-DRUPAL-6--2 instead of imagecache
Creating a symbolic link did not resolved my problem:
ln -s imagecache-DRUPAL-6--2 imagecache
It did not make any result :-(
So I changed it back to make an uggly workaround hack!

Here is the Hack on line 45s:

  else {
    $requirements[$key] += array(
      'description' => $t('This patch has not been properly applied to the following files (or the patch has been updated):') . '<br />' . theme('item_list', $unpatched_files) . '<br />' . t('Please consult the installation instructions in the included README.txt.'),
//      'severity'    => $not_properly_applied_severity,
      'severity'    => REQUIREMENT_OK,
      'value'       => $t('Not/incompletely applied patch or updated patch. - CONTROLLED BY HAND AND FORCED BY PATCH'),
    );
  }
}

It is written: I controlled by myself that patch has been correctly applied.
As this is not a way to go: Wim, have you any idea why the patch application has not been detected?

Alexandre

This is most definitely not a critical issue. Nothing breaks.

It works fine for me, so you'll have to do the research as to why it breaks. Any chance you're using Windows?

I have the same problemm tried it on a fresh clean install.
CDN: This patch file has been moved or deleted by the administrator. Please restore it, so we can verify that the patch has been properly applied.

Mr. Leers. Can you or someone recommend someone who knows how to install CDN with Imagecache going into Amazon S3.
Its all set up, I have been trying to make this work for 3 weeks.

For most here are tech, I have to make a living for my family.
Cannot find anyone even on Elance that can do this.

Best Regards.

You get that error because you deleted or moved the .patch files that shipped with the CDN module. Just restore it, and the error will disappear.

Instead of sticking with Amazon S3, which is far harder to set up because it is a Push CDN instead of an Origin Pull CDN (see http://wimleers.com/article/key-properties-of-a-cdn). Alternatively, you could use Amazon CloudFront, which is an Origin Pull CDN and is trivial to set up.

Finally, please don't go off topic.

Hey Wim, I'm looking at trying to get a sane version of this patch committed over in #570132: Support CDN rewriting of ImageCache paths but would love to have some one help understand why you're not calling hook_file_url_alter() on private URLs. I'm comparing that to what PressFlow has and it seems very different. Could you weigh in on it?