In line 184 of uc_sagepayserver.pages.inc the SQL is SELECT COUNT(*) no_rows....

On PostgreSQL 8.3.12 (Ubuntu) this returns an error. Sorry not sure how to create a patch file, so the code change provided here. If the query is written as follows:-

SELECT COUNT(*) AS no_rows FROM {uc_sagepayserver_transactions} WHERE vendor_transaction_code = '%s'

(Note the 'AS' after the count) - the query runs fine and the transaction completes. On PostgreSQL 8.4 this no longer seems to be an issue. However if this change doesn't cause issues on MySQL it would be fantastic to have it fixed.

By the way - thanks for a really great module.

Comments

leo pitt’s picture

leo pitt commented

Thanks for the report - apologies for the epic delay in response.

This should be resolved in the next development release. I'll post here when that's up.

leo pitt’s picture

leo pitt commented
Status: Active » Needs review

I've added your bug-fix to HEAD.

Please could you download the next development snapshot when it has been rebuilt, tomorrow, and confirm that it has been resolved?

Many Thanks

christoph’s picture

christoph commented

I've downloaded the development snapshot and tested against Sagepay Simulator. I confirm that this now works and the transaction completes normally. Thanks for your very quick response.

leo pitt’s picture

leo pitt commented

Thanks - Hopefully I'll have a new release in the next couple of days that includes this fix.

leo pitt’s picture

leo pitt commented
Status: Needs review » Fixed

Fixed in 6.x-1.4.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.