Insert's hook_menu() implementation duplicates menu paths for core image styles and breaks core image style paths; Insert adds the 'scheme' parameter of image_style_deliver() (which generates a styled image from an original image) to the page arguments--but that argument is now part of the image style path. It's possible that core now implements the behavior that insert_menu() tries to force.

This is fixable by removing Insert's hook_menu() implementation; Insert seems to behave even when clean URLs are off.

Also, I know this module is on hold until the D7 API stabilizes--I just wanted to document the issue.

CommentFileSizeAuthor
#1 insert-941000-hook-menu-removal.patch1.52 KBflorisla

Comments

florisla’s picture

Status: Active » Needs review
StatusFileSize
new1.52 KB

For testing purposes, this patch removes insert_menu().

So far I haven't seen any negative side effects.

florisla’s picture

The hook_menu() functionality is described as 'trickery' in #764782: Port to Drupal 7 (comment #2).

And #941000: Insert breaks styled images in Drupal 7 also seems to indicate that this workaround is no longer necessary...

florisla’s picture

Note: I meant #785980: Images may disappear when editing Image styles, not #941000 of course (wich is *this* issue)

quicksketch’s picture

Status: Needs review » Fixed

Yep, thank goodness we can now entirely remove this "hack". Thanks! Removed from CVS.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.