The attached patch adds in support for Maestro, Laser, Diners and Solo cards, and icons too.

Comments

jerdavis’s picture

Status: Needs review » Needs work

Hi Stella,

Could you please update and test the patch to include the javascript validation in theme/pay_cc.js?

Thanks!

Jeremiah

stella’s picture

Status: Needs work » Needs review
StatusFileSize
new8.74 KB

I've updated the patch so it now includes the correct validation in the javascript, but also adds support for the issue number field required by some card types (maestro / switch). In addition, it will hide the issue number and CCV2 fields depending on the card type selected, and will update the maxlength of the CCV2 field (4 for AMEX, 3 for others).

stella’s picture

StatusFileSize
new8.95 KB

Turns out some payment gateways still require switch and maestro to be treated separately, even though they are the one and the same now. Then also only switch cards (i.e. pre-2007) require issue number, but the new ones (which are maestro) do not. So updated patch attached.

allie micka’s picture

Status: Needs review » Closed (fixed)

Committed. Thanks Stella!

It will be necessary for payment gateways to exclude non-pertinent cards. For example, I don't think you can process some of these cards at all with Authorize.Net, but by default that gateway lists all cards as possible options. That module (authorizenet) will have to be amended to not list those cards on admin screens, and other gateway modules would exclude others.