Closed (fixed)
Project:
Genesis
Version:
7.x-1.1
Component:
Genesis Base Theme
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Oct 2010 at 11:41 UTC
Updated:
23 Jun 2012 at 15:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Jeff Burnz commentedGood timing, I'm working on G7 today/tomorrow. Will sort it out...
Comment #2
memcinto commentedThis turns out to be an error in the naming of the variable. It is $site_logo and it should be $logo. What I did on my test install was to copy page.tpl.php into my subtheme folder, then change all instances of $site_logo to $logo. That fixed it.
Comment #3
Argus commentedDon't know if it has anything to do with it, but I did the same as #2 and indeed got rid of the error messages. But now I can't get the site logo to work. I end up with:
<h1 class="logo-site-name"><span id="logo">http://localhost/sites/all/themes/genesis_themename/logo.png</span></h1>Comment #4
Jeff Burnz commented#2 is wrong, it just needs the variable to be initialized properly, I will add a fix today.
Comment #5
Vidus commentedHi, it seems I'm getting a variation of this error when I have logo turned off with the latest seven build:
Comment #6
jpincas commentedI'm having the same problem after turning the logo off. Here are my errors:
Notice: Undefined variable: site_logo in include() (line 87 of /home/jpincas/spanishfoodworld.co.uk/themes/genesis/genesis/templates/page.tpl.php).
Notice: Undefined variable: site_logo in include() (line 90 of /home/jpincas/spanishfoodworld.co.uk/themes/genesis/genesis/templates/page.tpl.php).
Notice: Undefined variable: site_logo in include() (line 93 of /home/jpincas/spanishfoodworld.co.uk/themes/genesis/genesis/templates/page.tpl.php).
Comment #7
Jeff Burnz commentedI thought I fixed this, hmmm, heres a patch for CVS, I'll commit this but probably won't roll a new release until after the Git migration (in about a week).
Comment #8
jpincas commentedThanks Jeff - I'll test this shortly. Jon
Comment #9
Rix-1 commentedI really need help with this, I have been building a site that I was hoping to go live today however am having the same problem: "Notice: Undefined variable: site_logo in include() (line 87 of ...."
I appreciate the patch above however I'm not sure how to patch something and after reading the Drupal documentation it says something like ' if you don't know how to patch then don't'.
Could someone point out how to fix this or what I need to do my end to remove the error from my Genesis sub-theme?
PS - Loving the Genesis framework, I've been through a few and this is by far the best.
Comment #10
Jeff Burnz commentedIn template.php (Genesis core) you can paste this into
genesis_preprocess_page(), starting around line 73 (you need to overwrite what is already there for site name and logo), what this does is just addselse {}statements to both the site_name and site_logo variables, so even if they're empty they're still defined:I have committed this fix to dev, so it should be in there in the next 24 hours or so, note that 7.x-2.x (the newer HTML5 version) does not have this problem at all, because it does things slightly differently.
Comment #11
Rix-1 commentedWow that was the fastest response ever!
I followed your instructions and it worked - thanks, I owe you a beer.
Comment #12
benjarlett commentedI do too.
Comment #14
Screenack commentedFYI -- seeing this in Genesis 7.x-1.1 added the above #10 as described and this fixed the problem.
Comment #15
ASMBL commentedAlso saw this error in 7.x-1.1. Also fixed with snipet in #10.
Thanks for the fix.
Comment #16
Tecnico informatico commentedHello,
Sorry, someone could indicate in more detail as you deploy the patch.
Specifically what is to be replaced within "template.php"?
Thanks in advance.
Manuel.
Comment #17
Tecnico informatico commentedHello,
I have the error:
"Notice: Undefined variable: site_logo in include ()"
The patch does not work because I do not know how it is implemented?
That line should be replaced with "template.php"
I do not know php.
Thanks in advance.
Comment #18
ivanhelguera commentedI can confirm this bug still happens in genesis-7.x-1.1.
@maligix :
you open template.php in your faveourite text editor, you find the two if statements around the line 73, and you replace them with what's shown here above (you paste the text form the codebox).
Important: do not paste the first (with "?php")nor the last line at the beginig of the above nor the "?" at the end. It's just an indication that the code is php, and what you paste into is a file full of php anyway (which has such statements at *its* beginning and end).
Comment #19
balavurda commentedI've been having the same problem. Suggested fix wasn't working for some reason. Fixed it a bit differently:
1. Go to page.tpl.php of your subtheme
2. On the line pointed as erroneous change if($site_logo... to if(isset($site_logo)...
Works fine with the logo on or off.