Active
Project:
Wysiwyg cleaner
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
15 Oct 2010 at 18:58 UTC
Updated:
8 Apr 2011 at 11:23 UTC
In the wake of modules like Features, there is a push to use machine names for identifying database content, rather than numeric ids. To this end, I recommend changing the preset ID (pid) field in {wysiwyg_cleaner_rules} to use such a machine name. For instance, I have a preset called "Deep Clean", which would have a pid of deep_clean (rather than 2).
Along these same lines, the current Rule ID (rid) field should be changed to a simple delta value, indicating the order of the rules within each preset. Currently it looks like the rid field is using a unique numeric ID, but this should not be counted on. It makes more sense for each preset to have its own order count, starting at zero.
Comments
Comment #1
jide commentedI have begun a large refactoring of the module using machine names some time ago. Still needs work, need to find some spare time to finish the effort.
Comment #2
smoothify commented@jide
I need to make this module exportable for a project, is there any chance of you committing your refactoring in its current state to save me working on the changes in a dead end fashion? Perhaps you could commit to a new branch in git, at least so I can see which path you've taken.
Thanks for your work on this module.
Comment #3
jide commented@smoothify I'll probably work on this in the next weeks, but I don't have a roadmap yet.