Needs work
Project:
Get Satisfaction
Version:
6.x-1.5
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Reporter:
Created:
15 Oct 2010 at 20:01 UTC
Updated:
5 Nov 2012 at 23:18 UTC
Jump to comment: Most recent file
With Drupal 7 beta1 already here, I was just wondering if any work had begun on a Drupal 7 port...
Thanks,
Ben
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | d7port-345675-5.patch | 3.3 KB | dabblela |
Comments
Comment #1
flevour commentedNot really at the moment. Could you help somehow in the development or testing?
Thank you,
Francesco
Comment #2
jeffwidman commentedsub
Comment #3
BenK commentedJust checking back in to see if there's any more interest. I don't have the time at the moment to do the heavy lifting on this, but could certainly do code reviews and testing.
--Ben
Comment #4
cparker15 commentedsubscribing
Comment #5
dabblela commentedAttached is a patch which brings the module into working shape for D7. Known issues:
-The filter stuff has not been ported at all
-Lots of PHP notices during save
-Not sure about the implementation of hook_page_build(). There's no real equivalent to hook_footer() in D7.
All that said, this puts a configurable GS tab on your D7 site.
Comment #6
dabblela commentedNW is a more appropriate label for this. Also, patch was made against head.
Comment #7
ezeedub commentedI suggest making a dev release so this effort shows up in upgrade_status's report.
Comment #8
clkeenan commentedSubscribed
Comment #9
chrishrtmn commentedSubscribed as well.
Comment #10
nimzie commentedsubscribed.
Is there any motion on this piece? Is there anything I can do to help? I'm no pro php but I can set up and test anything if need be.
Comment #11
mnestor commentedI wanted something a bit more than this module did in d6 so went and started from scratch. I've created a sandbox for it.
http://drupal.org/sandbox/mnestor/1490540
Key difference
-Multiple Search, Feedback, Topic list modules created as blocks
-Target the widget to a specific product you have in GetSatifaction by adding a field to your content so that when the widget block is displayed on a node page it will target to that node's GS-product field. The field is added by the module, you just have to hook it to the content types you plan to use it on.
Comment #12
flevour commentedInteresting contribution!
Are you willing to offer an upgrade path (if possible at all)?
If you like, I could give you write access to the repo so you could release a 7.x-2.x version.
Comment #13
mnestor commentedflevour,
That'd be awesome. I've been trying to clean up my code a bit before I emailed to ask you about that :)
Comment #14
flevour commentedI have added you as mantainer, you can directly manage releases.
I'd suggest creating a 7.x-2.x to make it clear this is not a development of the 1.x branch, but it's a complete rewrite.
As I stated above, it would be super-awesome if you could provide an upgrade path from people upgrading from 6.x-1.x.
I quickly reviewed your code and it's correctly formatted. It's missing some doc blocks, but as long as it works, it's should be enough to release a beta!
May I suggest you to try providing a test file too?
Thanks for your interest!
Francesco
Comment #15
mnestor commentedthanks flevour. I should be able to get in and polish things up more and put the branch up after next week. Trying to get my site launched first.
Comment #16
Davidis commentedsub
Comment #17
mgiffordAny thoughts on a release? Has anyone run this through Coder?
Comment #18
anniewang commentedsub