webform_file_download() needs to be updated for D7 (it's still calling file_check_location() and suchlike).

CommentFileSizeAuthor
#3 webform_file_directory_path.patch2.46 KBquicksketch
#1 942974-1-file-downloads.patch2.8 KBksenzee

Comments

ksenzee’s picture

ksenzee
she/her
commented
Status: Active » Needs review
StatusFileSize
new 942974-1-file-downloads.patch2.8 KB

This allows file download if

a) the file is recorded as belonging to a webform submission, and
b) the user either
- 1) is an admin who can see all submissions, or
- 2) has permission to see their own submissions, and originally uploaded the file.

It makes no attempt to distinguish among anonymous users, so if anon users can see their own submissions, they can see all anonymous submissions.

Stevel’s picture

Stevel commented
Status: Needs review » Reviewed & tested by the community

Looks good and works, so RTBC

quicksketch’s picture

quicksketch
he/him
commented
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new webform_file_directory_path.patch2.46 KB

Though I'm not real happy with having completely different code between D6 and D7, with the new File API it'd be hard to make these functions line up at at all between the two versions. Thanks for the patch and review guys.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.