The block_callback field in the {menu_router} table seems to be a curious leftover from pre-D6 at least.

It's only used in system_main_admin_page():

      if ($item['block_callback'] && function_exists($item['block_callback'])) {
        $function = $item['block_callback'];
        $block['content'] .= $function();
      }

There's not a single item in my menu_router table that has this set. On D6, there's only one, and it's not even relevant to system_main_admin_page()!

I reckon we can get rid of this.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim’s picture

Status: Active » Needs review
FileSize
1015 bytes

Let's see what the testbot makes of this ;)

joachim’s picture

Version: 8.x-dev » 7.x-dev

Testbot status 'ignored'? Is that because this is on 8? Hmm let's try it on 7.

moshe weitzman’s picture

tests pass. kill it.

joachim’s picture

Here's a patch that removes it all.

moshe weitzman’s picture

Needs an update function to drop the column, no?

joachim’s picture

moshe weitzman’s picture

Status: Needs review » Reviewed & tested by the community

Looks ready to me.

catch’s picture

nice.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

David_Rothstein’s picture

Status: Fixed » Needs work

It's not all the way gone yet...

David_Rothstein’s picture

Status: Needs work » Needs review
Issue tags: +API change
FileSize
1.59 KB

Now it is :)

By the way, is the original commit here an API change? It seems like it sort of is, although I'm not convinced this functionality worked as intended in D7 anymore anyway.

moshe weitzman’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -API change

RTBC.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.