Closed (fixed)
Project:
Menu Minipanels
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 Oct 2010 at 02:34 UTC
Updated:
22 Nov 2012 at 03:05 UTC
Jump to comment: Most recent file
Comments
Comment #1
watcha commentedThis patch changes the required folder from /js/lib to /sites/all/libraries
I think integration of the qtip module should be a separate feature request.
Comment #2
willieseabrook commentedHi,
Thanks for the patch, I'll take a look at it tomorrow
Comment #3
willieseabrook commentedComment #4
willieseabrook commentedThis is next on the list. High priority.
I just rolled a whole bunch of fixes to 6.x in and will wait a couple weeks for feedback on those before applying this patch with some changes.
Holding open for now.
Comment #5
lpalgarvio commented+1
consider optional support (module_exists()) for Libraries API
Comment #6
damienmckennaMarked this as a duplicate: #1196404: Proper Libraries API support
Comment #7
damienmckennaThis will be added to the next stable release.
Comment #8
damienmckennaHere's something I'm trying - I've spun off some code from hook_init() to a new function that a) checks a few possible paths:
The idea is to move the module's usage to having the qTip file in the sites/all/libraries/qtip directory, but also support existing installations that have the file in a subdirectory of the module's directory, and seeing as we're bothering with this at all just check for a few other possible incorrect locations; to offset the possible performance hit of doing the extra work the correctly identified path will be cached for later use.
As a result of this patch, the default location for the JS file will be "sites/all/libraries/qtip" but it will support the other locations above.
Comment #10
damienmckennaFYI I've looked at the qtip module and think that we'll just stick to Libraries API support for now and postpone the rest of this functionality for now.
Comment #11
damienmckennaI committed the patch from #8 to both branches.
Comment #12
damienmckennaA follow-up patch to add full Libraries API support.
Comment #13
damienmckennaAfter testing both the D6 and D7 versions, I've committed the patches from #12 too.
Comment #14
damienmckennaAm going to mark this issue Fixed and have moved the qtip.module-reuse into a separate issue: #1238884: Re-use qtip.module's admin functionality
Comment #16
hypertext200There was no any
hook_libraries_infoimplementation to support libraries, specially when we use profiles//libraries. So here is the patch to fix all those issues.
Comment #17
damienmckennaThe filename should be "jquery.qtip-1.0.0-rc3.min.js".
Comment #18
damienmckenna@heshan.lk: Lets take the Libraries API integration to #1847484: Full Libraries API support.
Comment #18.0
damienmckennadtet