Libraries normally should go into sites/all/libraries instead.

Then can that qtip module be used and this Menu MiniPanels be stripped down a bit for double routines?

Comments

watcha’s picture

This patch changes the required folder from /js/lib to /sites/all/libraries

I think integration of the qtip module should be a separate feature request.

willieseabrook’s picture

Hi,

Thanks for the patch, I'll take a look at it tomorrow

willieseabrook’s picture

Priority: Normal » Major
willieseabrook’s picture

Assigned: Unassigned » willieseabrook

This is next on the list. High priority.

I just rolled a whole bunch of fixes to 6.x in and will wait a couple weeks for feedback on those before applying this patch with some changes.

Holding open for now.

lpalgarvio’s picture

+1

consider optional support (module_exists()) for Libraries API

damienmckenna’s picture

Marked this as a duplicate: #1196404: Proper Libraries API support

damienmckenna’s picture

This will be added to the next stable release.

damienmckenna’s picture

Here's something I'm trying - I've spun off some code from hook_init() to a new function that a) checks a few possible paths:

  • 'sites/all/libraries/qtip'
  • $module_path . '/js/lib/qtip'
  • $module_path . '/js/lib'
  • $module_path . '/js/qtip'
  • $module_path . '/js'
  • $module_path . '/qtip'
  • $module_path

The idea is to move the module's usage to having the qTip file in the sites/all/libraries/qtip directory, but also support existing installations that have the file in a subdirectory of the module's directory, and seeing as we're bothering with this at all just check for a few other possible incorrect locations; to offset the possible performance hit of doing the extra work the correctly identified path will be cached for later use.

As a result of this patch, the default location for the JS file will be "sites/all/libraries/qtip" but it will support the other locations above.

damienmckenna’s picture

FYI I've looked at the qtip module and think that we'll just stick to Libraries API support for now and postpone the rest of this functionality for now.

damienmckenna’s picture

I committed the patch from #8 to both branches.

damienmckenna’s picture

A follow-up patch to add full Libraries API support.

damienmckenna’s picture

After testing both the D6 and D7 versions, I've committed the patches from #12 too.

damienmckenna’s picture

Status: Active » Fixed

Am going to mark this issue Fixed and have moved the qtip.module-reuse into a separate issue: #1238884: Re-use qtip.module's admin functionality

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

hypertext200’s picture

Version: 6.x-1.0 » 7.x-1.x-dev
Assigned: damienmckenna » Unassigned
Status: Closed (fixed) » Needs review
StatusFileSize
new834 bytes

There was no any hook_libraries_info implementation to support libraries, specially when we use profiles/
/libraries. So here is the patch to fix all those issues.

damienmckenna’s picture

Status: Needs review » Needs work

The filename should be "jquery.qtip-1.0.0-rc3.min.js".

damienmckenna’s picture

Status: Needs work » Closed (fixed)

@heshan.lk: Lets take the Libraries API integration to #1847484: Full Libraries API support.

damienmckenna’s picture

Issue summary: View changes

dtet