Right now we have duplicate code/text regarding the aspects (in SINGEME.txt, PLAYME.txt and powerballad_load_aspect()).

We should remove the SINGME.txt and PLAYME.txt files and replace them with [aspect].txt. That aspect file will then be parsed inside powerballad_load_aspect() and split by line into the appropriate array. This could easily be done with the file() function.

By doing this we can separate the text, chords and aspect loading and avoid duplicate code/texts.

Comments

itangalo’s picture

itangalo commented

I've been thinking something similar, and I definately agree.
Before it can be done there must be a way of handling the inline breaks for the lyrics – ie that line number one could be written both

It feels so lonely late at night / wrapping up a piece of code

and

It feels so lonely late at night
  wrapping up a piece of code

I suppose a check for the standard Drupal indent could work.