The taxonomy description is currently not used anywhere else that in the feed description.
I -and I am sure others too- expect the taxonomy description to show up on the site. The most logical place for that to be would be the top of taxo listings. /taxonomy/page/or/1 should show taxonomyterm1's description above the list of nodes in that term. /taxonomy/page/or/1,3,4 the descriptions of 1,3 and four. etceteras.
This patch does that.
The description is pulled throug the filters too, so that title tags, image tags etc can be used if one likes.
I am a bit reluctant to adding a configuration option like "show taxonomy term on top of taxonomy listings". Because I think that if you don't what the description to show up you would not need a description in the first place.
And besides all that. The listing is now (after this patch) handled by a themeable function, so if you really feel the need for removing descriptions from the top, you can do so in a theme function.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | taxonomy_themeable_0.patch | 3.41 KB | Bèr Kessels |
| taxonomy_themeable.patch | 3.35 KB | Bèr Kessels |
Comments
Comment #1
TDobes commentedHow would this patch deal with taxonomy/page/and queries? It's difficult to predict which descriptions would be desired in that case.
Comment #2
Bèr Kessels commentedThe same.
It just shows a list of all the mentioned terms. So and/1,2,3 will show the descriptions of one and two and three.
I improved the patch a bit more. Some minor tweakings in some 'ugly' code that was there already.
Note that the patch also allows theme developers to say, for example, that the title of a page is You are looking at articles in categories X and Y and Z. instead of the default old hardcoded X, Y, Z
Comment #3
Steven commentedThis patch no longer applies due to the taxonomy URL changes.
Comment #4
Bèr Kessels commentedA quick question:
Is there any chance this makes it into core? In other words, should I consider wasting my time on fixing a patch that most probably will never make it into the core?
Ber
Comment #5
Bèr Kessels commentedhttp://drupal.org/node/10399 is a better and newer approach
Comment #6
nedjoWhile the idea (yet to get much response) of adding a 'view' option to the _taxonomy() hook, as suggested in the issue http://drupal.org/node/10399 would be one way of adding in term descriptions via a contributed module, I think Ber is right here--having a term description listed at the top of category views is the expected behaviour--at least when a single category (as opposed to a combination of categories, via an OR or AND operator) is being viewed. Site admins shouldn't have to search around to find a contributed module to get this functionality--it belongs in core.
Would it make sense to do this straight in the taxonomy module, rather than via theming?
Comment #7
Bèr Kessels commentedMy patch does pu this into taxonomy by default. But it also provides an option for themes to override the default of displaying that description. For example if they do not want to show it, or if they want to re-order, or markup the output.
So all you say is implemented ain this patch. I am afraid, though that this patch no longer applies. But I am very short in time and am not able to remake this patch ATM.
Ber
Comment #8
Bèr Kessels commentedDo we still want such a feature? If not, i will close this issue.
Comment #9
zach harkey commentedWould this make the taxonomy_context module unnecessary?
Comment #10
Bèr Kessels commentedyes. this patch does (did? its old) the same thing that taxonomy context does. IMO this feature should be in core, not in a contrib module.
Comment #11
moshe weitzman commentedi think a contrib module could do this today using block regions (in HEAD only).
Comment #12
LAsan commentedDo we still want such a feature? If not, close this issue.
Comment #13
chrisschaub commentedI hope this can make core -- taxonomy context is not a great solution in the long run. If you can figure out which description to show for feeds, then it can be worked out for page displays? Maybe only show if there is a single term being viewed. I think this is another example of finding ways to make taxonomy more useful for average users.
Comment #14
webchickThis was fixed in 6.x.
See http://webchick.net/contributor-spotlight which is a taxonomy listing and contains the vocabulary description at the top.
Comment #15
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.