table input.fluid in core.css sets width to auto, which makes multi value node reference fields far too short.

Here is my quick fix but I have not fully tested that it doesn't cause other ill effects.

CommentFileSizeAuthor
#10 rubik-table_input_fluid-944534-10.patch853 byteswbobeirne
#6 rubik-table_input_fluid-944534-5.patch852 bytescodi
#1 rubik-table_input_fluid-944534.patch371 bytestirdadc
rubik-table_input_fluid.patch390 bytesagileware

Comments

tirdadc’s picture

tirdadc commented
StatusFileSize
new rubik-table_input_fluid-944534.patch371 bytes

Setting it to 97% works better though. Thanks for the fix.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
commented

Why 97% ?
input.fluid is set to width:100% in the previous declaration. Does it need to be shorter when in a table?
The original patch applies and is working for me in 7.x-4.0-beta8.

devonwarren’s picture

devonwarren commented
Version: 6.x-3.0-beta2 » 7.x-4.0-beta8

Patch works for me in 4.0-beta8 as well. I am using the node reference field from the references module (7.x-2.0) on Chrome 19 btw.

victoriachan’s picture

victoriachan commented

Thanks, patch works for me, and I've not noticed any ill effects. Perhaps it can committed?

codi’s picture

codi commented
Version: 7.x-4.0-beta8 » 7.x-4.x-dev
Status: Needs review » Reviewed & tested by the community

I've re-rolled the patch to work with the dev branch. Removed the width:auto on the input and added 10px of padding around the table cells to bring the white space around it inline with other fields.

Reviewed by co-workers.

codi’s picture

codi commented
StatusFileSize
new rubik-table_input_fluid-944534-5.patch852 bytes

Sorry, patch attached.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
commented
Status: Reviewed & tested by the community » Needs review

Needs community review.

cesarmiquel’s picture

cesarmiquel commented

Tested on Linux with Chrome Version 21.0.1180.79 and everything works ok. Had the same issue with Rubik.

wbobeirne’s picture

wbobeirne commented
Status: Needs review » Reviewed & tested by the community

Before: http://cl.ly/image/3T3j0V2V1b45
After: http://cl.ly/image/1S1A1w1k0O1l

Not sure I like the padding (I got used to that cramped look), but it does as advertised.

wbobeirne’s picture

wbobeirne commented
StatusFileSize
new rubik-table_input_fluid-944534-10.patch853 bytes

Having an issue where #5 is not applying on CentOS 6.3, some issue with line #33 which looks malformed somehow. Attaching a patch that shouldn't have that issue.

othermachines’s picture

othermachines commented

#10 reviewed and confirmed working. Thanks!

Wow, just realized this issue is 2-1/2 years old.

haydeniv’s picture

haydeniv commented
Status: Reviewed & tested by the community » Fixed

Committed: e4d0752

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.