CVS edit link for ivoh

I would like to add a new module for Apache Solr indexing.
CommentFileSizeAuthor
#9 apachesolr_location-1.3.zip1.51 KBreneve2010
#6 apachesolr_location-1.2.zip1.76 KBreneve2010
#3 apachesolr_location.zip1.77 KBreneve2010
#1 apachesolr_location.zip1.78 KBreneve2010

Comments

reneve2010’s picture

reneve2010 commented
Title: ivoh [ivoh] » Contribution apachesolr_location available for review.
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new apachesolr_location.zip1.78 KB

Contribution apachesolr_location available for review.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Contribution apachesolr_location available for review. » ivoh [ivoh]
Status: Needs review » Needs work
Issue tags: +Module review

Hello, and thank you for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site; for modules, it should include also a comparison with the existing solutions.

reneve2010’s picture

reneve2010 commented
StatusFileSize
new apachesolr_location-1.1.zip1.77 KB

Motivation: Existing modules do not include the possibility to index a Location CCK field. This module makes it possible to index the Location CCK field, and more specifically the country field, which is a sub-field of a Location CCK field. Next to that, it enables an ApacheSolr facet allowing the user to search for nodes within a specific country.

Similar projects:

  • http://drupal.org/project/localsolr - the localsolr module is not maintained anymore and does not index the country field itself. In addition it does not allow the user to create a ApacheSolr facet on the country field.

Planned future features:

  • Also index the city field.
  • Create a facet on the city field, which depends on the selected country facets.
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review

Thank you for your reply.

brianV’s picture

brianV commented
Title: ivoh [ivoh] » ivoh [ivoh]
Status: Needs review » Needs work

Some notes:

  1. Please remove the version string from the .info files. It's updated / added automatically by the CVS packaging script.
  2. Please add an @file docblock to the top of your .module file. See http://drupal.org/node/1354#files
  3. Please fix the docblocks for apachesolr_location_apachesolr_prepare_query() and apachesolr_location_index_key().
  4. Please remove the commented out lines of code, if they are not necessary.

Once those are done, this module should be ready to go.

reneve2010’s picture

reneve2010 commented
StatusFileSize
new apachesolr_location-1.2.zip1.76 KB

@brianV Thanks for the comments. I fixed them. Is the module ready to go?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
brianV’s picture

brianV commented
Status: Needs review » Needs work

ivoh:

It looks good to me except for this comment, which seems to be some cruft from another module you based this one on:

// Each widget type gets its own array. Filefield_widget and imagefield_widget
// are the two we concern ourselves with.
reneve2010’s picture

reneve2010 commented
StatusFileSize
new apachesolr_location-1.3.zip1.51 KB

@brianV Thanks. Yes, you are correct that was from a piece of example code. I removed it. See final version as attached.

Are we ready to go?

brianV’s picture

brianV commented

Sorry to make you keep having to jump through hoops, but I found two other issues:

  1. Please add CVS $Id$ tags to your two files as per http://drupal.org/handbook/cvs/faq.
  2. Also, can you add a simple README.txt to the module explaining what it is, what it does and what it depends on?

After this, everything should be good (for real this time!)

zzolo’s picture

zzolo commented
Component: Miscellaneous » miscellaneous
Status: Needs work » Closed (won't fix)

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

  • The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
  • Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.
BeaPower’s picture

BeaPower commented

Has this been reviewed and approved? Need this module.

ivanbreet’s picture

ivanbreet commented

+1

deepbluesolutions’s picture

deepbluesolutions commented

Hi Ivoh

Just trying to test your module,
Solr is installed and working, location_cck installed and a content type is setup with a location cck field,

when i look in

/admin/settings/apachesolr/enabled-filters

I see a heading for apachesolr_location, but there is nothing under it ? is there anything else I need to install?

thanks

Daren

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: miscellaneous » new project application
Issue summary: View changes